Re: [PATCH v2] pwm: add pca9685 driver

2013-05-28 Thread Thierry Reding
On Tue, May 28, 2013 at 09:38:01AM +0200, Steffen Trumtrar wrote: > On Mon, May 27, 2013 at 09:13:34PM +0200, Thierry Reding wrote: > > On Mon, May 27, 2013 at 11:28:27AM +0200, Steffen Trumtrar wrote: [...] > > > +Optional properties: > > > + - invrt: <0> output logic state not inverted > > > +

Re: [PATCH v2] pwm: add pca9685 driver

2013-05-28 Thread Steffen Trumtrar
Hi! On Mon, May 27, 2013 at 09:13:34PM +0200, Thierry Reding wrote: > On Mon, May 27, 2013 at 11:28:27AM +0200, Steffen Trumtrar wrote: > > Add pwm driver for the NXP pca9685 16 channel pwm-led controller. > > Please stick to the all-caps spelling of PWM in prose. Also why is this > called

Re: [PATCH v2] pwm: add pca9685 driver

2013-05-28 Thread Steffen Trumtrar
Hi! On Mon, May 27, 2013 at 09:13:34PM +0200, Thierry Reding wrote: On Mon, May 27, 2013 at 11:28:27AM +0200, Steffen Trumtrar wrote: Add pwm driver for the NXP pca9685 16 channel pwm-led controller. Please stick to the all-caps spelling of PWM in prose. Also why is this called pwm-led?

Re: [PATCH v2] pwm: add pca9685 driver

2013-05-28 Thread Thierry Reding
On Tue, May 28, 2013 at 09:38:01AM +0200, Steffen Trumtrar wrote: On Mon, May 27, 2013 at 09:13:34PM +0200, Thierry Reding wrote: On Mon, May 27, 2013 at 11:28:27AM +0200, Steffen Trumtrar wrote: [...] +Optional properties: + - invrt: 0 output logic state not inverted + 1 output

Re: [PATCH v2] pwm: add pca9685 driver

2013-05-27 Thread Thierry Reding
On Mon, May 27, 2013 at 11:28:27AM +0200, Steffen Trumtrar wrote: > Add pwm driver for the NXP pca9685 16 channel pwm-led controller. Please stick to the all-caps spelling of PWM in prose. Also why is this called pwm-led? Can't the generated PWM signal be used for other purposes? > The driver is

[PATCH v2] pwm: add pca9685 driver

2013-05-27 Thread Steffen Trumtrar
Add pwm driver for the NXP pca9685 16 channel pwm-led controller. The driver is really barebones at this stage. E.g. the OE' pin and therefore the according registers are not supported. The driver was tested on a HW where this pin is tied to GND. Signed-off-by: Steffen Trumtrar --- Changes

[PATCH v2] pwm: add pca9685 driver

2013-05-27 Thread Steffen Trumtrar
Add pwm driver for the NXP pca9685 16 channel pwm-led controller. The driver is really barebones at this stage. E.g. the OE' pin and therefore the according registers are not supported. The driver was tested on a HW where this pin is tied to GND. Signed-off-by: Steffen Trumtrar

Re: [PATCH v2] pwm: add pca9685 driver

2013-05-27 Thread Thierry Reding
On Mon, May 27, 2013 at 11:28:27AM +0200, Steffen Trumtrar wrote: Add pwm driver for the NXP pca9685 16 channel pwm-led controller. Please stick to the all-caps spelling of PWM in prose. Also why is this called pwm-led? Can't the generated PWM signal be used for other purposes? The driver is