Re: [PATCH v2] rbtree: fix the red root

2019-01-18 Thread Qian Cai
On 1/16/19 9:37 AM, Esme wrote: > I have been off but back now, I had fetch'd current again and the diagnostics > look a bit different, maybe I just got lucky. Instead of fork'ng the test > case (which is fairly aggressive in any case), interacting from the serial > port with sig-int ^C

Re: [PATCH v2] rbtree: fix the red root

2019-01-14 Thread Qian Cai
> [ 114.913404] Padding 6913c65d: 00 00 00 00 00 00 00 00 00 00 00 00 > 00 00 00 00 > [ 114.915437] Padding 2d53f25c: 00 00 00 00 00 00 00 00 00 00 00 00 > 00 00 00 00 > [ 114.917390] Padding 78f7d621: 00 00 00 00 00 00 00 00 00 00

Re: [PATCH v2] rbtree: fix the red root

2019-01-14 Thread Douglas Gilbert
On 2019-01-14 12:58 p.m., Qian Cai wrote: Unfortunately, I could not trigger any of those here both in a bare-metal and virtual machines. All I triggered were hung tasks and soft-lockup due to fork bomb. The only other thing I can think of is to setup kdump to capture a vmcore when either GPF

Re: [PATCH v2] rbtree: fix the red root

2019-01-14 Thread Qian Cai
Unfortunately, I could not trigger any of those here both in a bare-metal and virtual machines. All I triggered were hung tasks and soft-lockup due to fork bomb. The only other thing I can think of is to setup kdump to capture a vmcore when either GPF or BUG() happens, and then share the vmcore

Re: [PATCH v2] rbtree: fix the red root

2019-01-14 Thread Esme
Disabled kmemleak options. On mobile, pardon brevity. Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Monday, January 14, 2019 10:45 AM, Qian Cai wrote: > On 1/14/19 1:23 AM, Esme wrote: > > > I did not yet verify the previous branches but did tune out kmemleak > >

Re: [PATCH v2] rbtree: fix the red root

2019-01-14 Thread Qian Cai
On 1/14/19 1:23 AM, Esme wrote: > I did not yet verify the previous branches but did tune out kmemleak > (CONFIG_DEBUG_MEMLEAK no longer set) as it seemed a bit obtrusive in this > matter, this is what I see now (note redzone?). > /Esme > > 114.826116] >

Re: [PATCH v2] rbtree: fix the red root

2019-01-13 Thread Esme
‐‐‐ Original Message ‐‐‐ On Sunday, January 13, 2019 11:52 PM, Douglas Gilbert wrote: > On 2019-01-13 10:59 p.m., Esme wrote: > > > ‐‐‐ Original Message ‐‐‐ > > On Sunday, January 13, 2019 10:52 PM, Douglas Gilbert dgilb...@interlog.com > > wrote: > > > > > On 2019-01-13 10:07

Re: [PATCH v2] rbtree: fix the red root

2019-01-13 Thread Douglas Gilbert
On 2019-01-13 10:59 p.m., Esme wrote: ‐‐‐ Original Message ‐‐‐ On Sunday, January 13, 2019 10:52 PM, Douglas Gilbert wrote: On 2019-01-13 10:07 p.m., Esme wrote: ‐‐‐ Original Message ‐‐‐ On Sunday, January 13, 2019 9:33 PM, Qian Cai c...@lca.pw wrote: On 1/13/19 9:20 PM,

Re: [PATCH v2] rbtree: fix the red root

2019-01-13 Thread Esme
‐‐‐ Original Message ‐‐‐ On Sunday, January 13, 2019 10:52 PM, Douglas Gilbert wrote: > On 2019-01-13 10:07 p.m., Esme wrote: > > > ‐‐‐ Original Message ‐‐‐ > > On Sunday, January 13, 2019 9:33 PM, Qian Cai c...@lca.pw wrote: > > > > > On 1/13/19 9:20 PM, David Lechner wrote: >

Re: [PATCH v2] rbtree: fix the red root

2019-01-13 Thread Douglas Gilbert
On 2019-01-13 10:07 p.m., Esme wrote: ‐‐‐ Original Message ‐‐‐ On Sunday, January 13, 2019 9:33 PM, Qian Cai wrote: On 1/13/19 9:20 PM, David Lechner wrote: On 1/11/19 8:58 PM, Michel Lespinasse wrote: On Fri, Jan 11, 2019 at 3:47 PM David Lechner da...@lechnology.com wrote: On

Re: [PATCH v2] rbtree: fix the red root

2019-01-13 Thread Esme
‐‐‐ Original Message ‐‐‐ On Sunday, January 13, 2019 9:33 PM, Qian Cai wrote: > On 1/13/19 9:20 PM, David Lechner wrote: > > > On 1/11/19 8:58 PM, Michel Lespinasse wrote: > > > > > On Fri, Jan 11, 2019 at 3:47 PM David Lechner da...@lechnology.com wrote: > > > > > > > On 1/11/19 2:58

Re: [PATCH v2] rbtree: fix the red root

2019-01-13 Thread Qian Cai
On 1/13/19 9:20 PM, David Lechner wrote: > On 1/11/19 8:58 PM, Michel Lespinasse wrote: >> On Fri, Jan 11, 2019 at 3:47 PM David Lechner wrote: >>> >>> On 1/11/19 2:58 PM, Qian Cai wrote: A GPF was reported, kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by

Re: [PATCH v2] rbtree: fix the red root

2019-01-13 Thread David Lechner
On 1/11/19 8:58 PM, Michel Lespinasse wrote: On Fri, Jan 11, 2019 at 3:47 PM David Lechner wrote: On 1/11/19 2:58 PM, Qian Cai wrote: A GPF was reported, kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1]

Re: [PATCH v2] rbtree: fix the red root

2019-01-11 Thread Michel Lespinasse
On Fri, Jan 11, 2019 at 3:47 PM David Lechner wrote: > > On 1/11/19 2:58 PM, Qian Cai wrote: > > A GPF was reported, > > > > kasan: CONFIG_KASAN_INLINE enabled > > kasan: GPF could be caused by NULL-ptr deref or user memory access > > general protection fault: [#1] SMP KASAN > >

Re: [PATCH v2] rbtree: fix the red root

2019-01-11 Thread Esme
I've been out today but return home tomorrow and can test any suggested fixes, or with different kernel settings. Just let me know. Esme Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Friday, January 11, 2019 7:18 PM, Qian Cai wrote: > On 1/11/19 6:16 PM, Matthew

Re: [PATCH v2] rbtree: fix the red root

2019-01-11 Thread Qian Cai
On 1/11/19 6:16 PM, Matthew Wilcox wrote: > On Fri, Jan 11, 2019 at 03:58:43PM -0500, Qian Cai wrote: >> diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c >> index b7055b2a07d3..afad0213a117 100644 >> --- a/lib/rbtree_test.c >> +++ b/lib/rbtree_test.c >> @@ -345,6 +345,17 @@ static int __init

Re: [PATCH v2] rbtree: fix the red root

2019-01-11 Thread David Lechner
On 1/11/19 2:58 PM, Qian Cai wrote: A GPF was reported, kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN kasan_die_handler.cold.22+0x11/0x31 notifier_call_chain+0x17b/0x390

Re: [PATCH v2] rbtree: fix the red root

2019-01-11 Thread Matthew Wilcox
On Fri, Jan 11, 2019 at 03:58:43PM -0500, Qian Cai wrote: > diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c > index b7055b2a07d3..afad0213a117 100644 > --- a/lib/rbtree_test.c > +++ b/lib/rbtree_test.c > @@ -345,6 +345,17 @@ static int __init rbtree_test_init(void) > check(0); >

[PATCH v2] rbtree: fix the red root

2019-01-11 Thread Qian Cai
A GPF was reported, kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN kasan_die_handler.cold.22+0x11/0x31 notifier_call_chain+0x17b/0x390 atomic_notifier_call_chain+0xa7/0x1b0