Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-20 11:12:10 [-0700], Paul E. McKenney wrote: > We could name it something like "use_softirq" and initialize it to true. > I am OK either way. I had to add one hunk to get it compiled. It worked then. Let me swap the logic as you suggested and then I repost the whole thing. This will

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Paul E. McKenney
On Wed, Mar 20, 2019 at 06:59:52PM +0100, Sebastian Andrzej Siewior wrote: > On 2019-03-20 10:30:01 [-0700], Paul E. McKenney wrote: > > On Wed, Mar 20, 2019 at 05:35:32PM +0100, Sebastian Andrzej Siewior wrote: > > > On 2019-03-20 09:15:00 [-0700], Paul E. McKenney wrote: > > > > I am considering

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-20 10:30:01 [-0700], Paul E. McKenney wrote: > On Wed, Mar 20, 2019 at 05:35:32PM +0100, Sebastian Andrzej Siewior wrote: > > On 2019-03-20 09:15:00 [-0700], Paul E. McKenney wrote: > > > I am considering making it a module_param() to avoid namespace pollution, > > > as it would become

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Paul E. McKenney
On Wed, Mar 20, 2019 at 05:35:32PM +0100, Sebastian Andrzej Siewior wrote: > On 2019-03-20 09:15:00 [-0700], Paul E. McKenney wrote: > > I am considering making it a module_param() to avoid namespace pollution, > > as it would become something like rcutree.nosoftirq. > > > > Thoughts? > > nope,

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-20 09:15:00 [-0700], Paul E. McKenney wrote: > I am considering making it a module_param() to avoid namespace pollution, > as it would become something like rcutree.nosoftirq. > > Thoughts? nope, perfect. > Thanx, Paul Sebastian

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Paul E. McKenney
On Wed, Mar 20, 2019 at 05:05:48PM +0100, Sebastian Andrzej Siewior wrote: > On 2019-03-20 08:44:40 [-0700], Paul E. McKenney wrote: > > > > And it does seem to work better. I will give it more intense testing > > later on, but in the meantime I have merged this change into your > > earlier

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-20 08:44:40 [-0700], Paul E. McKenney wrote: > > And it does seem to work better. I will give it more intense testing > later on, but in the meantime I have merged this change into your > earlier patch. thanks. > We will see whether or not I am able summon up the courage to push it

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Paul E. McKenney
On Wed, Mar 20, 2019 at 08:21:46AM -0700, Paul E. McKenney wrote: > On Wed, Mar 20, 2019 at 12:32:19PM +0100, Sebastian Andrzej Siewior wrote: > > On 2019-03-19 12:44:19 [+0100], To Paul E. McKenney wrote: > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > > index

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Paul E. McKenney
On Wed, Mar 20, 2019 at 12:32:19PM +0100, Sebastian Andrzej Siewior wrote: > On 2019-03-19 12:44:19 [+0100], To Paul E. McKenney wrote: > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > index 0f31b79eb6761..0a719f726e149 100644 > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > … >

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-19 12:44:19 [+0100], To Paul E. McKenney wrote: > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 0f31b79eb6761..0a719f726e149 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c … > +/* > + * Spawn per-CPU RCU core processing kthreads. > + */ > +static int __init

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-19 Thread Sebastian Andrzej Siewior
On 2019-03-19 09:50:07 [-0700], Paul E. McKenney wrote: > Besides, it looks very weird for me to have two Signed-off-by lines. ;-) See commit 602cae04c4864 ("perf/x86/intel: Delay memory deallocation until x86_pmu_dead_cpu()") > In theory, the trace_rcu_utilization() should be added, just like

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-19 Thread Paul E. McKenney
On Tue, Mar 19, 2019 at 05:24:31PM +0100, Sebastian Andrzej Siewior wrote: > On 2019-03-19 08:59:23 [-0700], Paul E. McKenney wrote: > > I doubt that there is any code left from my original, so I set you as > > author. > > I always forward ported it the patch over the years. So if it is no >

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-19 Thread Sebastian Andrzej Siewior
On 2019-03-19 08:59:23 [-0700], Paul E. McKenney wrote: > I doubt that there is any code left from my original, so I set you as > author. I always forward ported it the patch over the years. So if it is no longer what it was once so be it. > I queued this and am starting tests without setting

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-19 Thread Paul E. McKenney
On Tue, Mar 19, 2019 at 12:44:19PM +0100, Sebastian Andrzej Siewior wrote: > From: "Paul E. McKenney" > > Running RCU out of softirq is a problem for some workloads that would > like to manage RCU core processing independently of other softirq work, > for example, setting kthread priority. >

[PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-19 Thread Sebastian Andrzej Siewior
From: "Paul E. McKenney" Running RCU out of softirq is a problem for some workloads that would like to manage RCU core processing independently of other softirq work, for example, setting kthread priority. This commit therefore introduces the `rcunosoftirq' option which moves the RCU core work