Re: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE

2018-01-02 Thread Erick Chen
Hi Axel, On 一, 1月 01, 2018 at 08:38:50下午 +0800, Axel Lin wrote: > The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes > regmap_write() call looks strange because it takes reg parameter fist > then val. > Base on Erick's suggestion to define SC2731_PWR_WR_PROT and >

Re: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE

2018-01-02 Thread Erick Chen
Hi Axel, On 一, 1月 01, 2018 at 08:38:50下午 +0800, Axel Lin wrote: > The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes > regmap_write() call looks strange because it takes reg parameter fist > then val. > Base on Erick's suggestion to define SC2731_PWR_WR_PROT and >

[PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE

2018-01-01 Thread Axel Lin
The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes regmap_write() call looks strange because it takes reg parameter fist then val. Base on Erick's suggestion to define SC2731_PWR_WR_PROT and SC2731_WR_UNLOCK_VALUE instead. Signed-off-by: Axel Lin ---

[PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE

2018-01-01 Thread Axel Lin
The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes regmap_write() call looks strange because it takes reg parameter fist then val. Base on Erick's suggestion to define SC2731_PWR_WR_PROT and SC2731_WR_UNLOCK_VALUE instead. Signed-off-by: Axel Lin ---