Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-11 Thread Ram Pai
On Wed, Apr 11, 2018 at 08:16:33AM +0200, Takashi Iwai wrote: > On Wed, 11 Apr 2018 02:37:44 +0200, > Ram Pai wrote: > > > > On Tue, Apr 10, 2018 at 01:42:39PM -0700, Andrew Morton wrote: > > > On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > > > > > > > On Tue, 10 Apr

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-11 Thread Ram Pai
On Wed, Apr 11, 2018 at 08:16:33AM +0200, Takashi Iwai wrote: > On Wed, 11 Apr 2018 02:37:44 +0200, > Ram Pai wrote: > > > > On Tue, Apr 10, 2018 at 01:42:39PM -0700, Andrew Morton wrote: > > > On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > > > > > > > On Tue, 10 Apr 2018 02:23:26

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-11 Thread Takashi Iwai
On Wed, 11 Apr 2018 02:37:44 +0200, Ram Pai wrote: > > On Tue, Apr 10, 2018 at 01:42:39PM -0700, Andrew Morton wrote: > > On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > > > > > On Tue, 10 Apr 2018 02:23:26 +0200, > > > Andrew Morton wrote: > > > > > > > > On Sun, 8

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-11 Thread Takashi Iwai
On Wed, 11 Apr 2018 02:37:44 +0200, Ram Pai wrote: > > On Tue, Apr 10, 2018 at 01:42:39PM -0700, Andrew Morton wrote: > > On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > > > > > On Tue, 10 Apr 2018 02:23:26 +0200, > > > Andrew Morton wrote: > > > > > > > > On Sun, 8 Apr 2018 09:20:26

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-10 Thread Ram Pai
On Tue, Apr 10, 2018 at 01:42:39PM -0700, Andrew Morton wrote: > On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > > > On Tue, 10 Apr 2018 02:23:26 +0200, > > Andrew Morton wrote: > > > > > > On Sun, 8 Apr 2018 09:20:26 +0200 Takashi Iwai wrote: > > > > >

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-10 Thread Ram Pai
On Tue, Apr 10, 2018 at 01:42:39PM -0700, Andrew Morton wrote: > On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > > > On Tue, 10 Apr 2018 02:23:26 +0200, > > Andrew Morton wrote: > > > > > > On Sun, 8 Apr 2018 09:20:26 +0200 Takashi Iwai wrote: > > > > > > > We've got a bug report

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-10 Thread Andrew Morton
On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > On Tue, 10 Apr 2018 02:23:26 +0200, > Andrew Morton wrote: > > > > On Sun, 8 Apr 2018 09:20:26 +0200 Takashi Iwai wrote: > > > > > We've got a bug report indicating a kernel panic at booting on an > > >

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-10 Thread Andrew Morton
On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > On Tue, 10 Apr 2018 02:23:26 +0200, > Andrew Morton wrote: > > > > On Sun, 8 Apr 2018 09:20:26 +0200 Takashi Iwai wrote: > > > > > We've got a bug report indicating a kernel panic at booting on an > > > x86-32 system, and it turned out

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-09 Thread Takashi Iwai
On Tue, 10 Apr 2018 02:23:26 +0200, Andrew Morton wrote: > > On Sun, 8 Apr 2018 09:20:26 +0200 Takashi Iwai wrote: > > > We've got a bug report indicating a kernel panic at booting on an > > x86-32 system, and it turned out to be the invalid resource assigned > > after PCI

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-09 Thread Takashi Iwai
On Tue, 10 Apr 2018 02:23:26 +0200, Andrew Morton wrote: > > On Sun, 8 Apr 2018 09:20:26 +0200 Takashi Iwai wrote: > > > We've got a bug report indicating a kernel panic at booting on an > > x86-32 system, and it turned out to be the invalid resource assigned > > after PCI resource

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-09 Thread Andrew Morton
On Sun, 8 Apr 2018 09:20:26 +0200 Takashi Iwai wrote: > We've got a bug report indicating a kernel panic at booting on an > x86-32 system, and it turned out to be the invalid resource assigned > after PCI resource reallocation. __find_resource() first aligns the > resource start

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-09 Thread Andrew Morton
On Sun, 8 Apr 2018 09:20:26 +0200 Takashi Iwai wrote: > We've got a bug report indicating a kernel panic at booting on an > x86-32 system, and it turned out to be the invalid resource assigned > after PCI resource reallocation. __find_resource() first aligns the > resource start address and

[PATCH v2] resource: Fix integer overflow at reallocation

2018-04-08 Thread Takashi Iwai
We've got a bug report indicating a kernel panic at booting on an x86-32 system, and it turned out to be the invalid resource assigned after PCI resource reallocation. __find_resource() first aligns the resource start address and resets the end address with start+size-1 accordingly, then checks

[PATCH v2] resource: Fix integer overflow at reallocation

2018-04-08 Thread Takashi Iwai
We've got a bug report indicating a kernel panic at booting on an x86-32 system, and it turned out to be the invalid resource assigned after PCI resource reallocation. __find_resource() first aligns the resource start address and resets the end address with start+size-1 accordingly, then checks