Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-11-01 Thread Ingo Molnar
* Matthias Kaehlcke wrote: > El Tue, Oct 30, 2017 at 10:57:58AM +0100 Ingo Molnar ha dit: > > > * Matthias Kaehlcke wrote: > > > > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > > and sysctl_sched_time_avg includes the

Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-11-01 Thread Ingo Molnar
* Matthias Kaehlcke wrote: > El Tue, Oct 30, 2017 at 10:57:58AM +0100 Ingo Molnar ha dit: > > > * Matthias Kaehlcke wrote: > > > > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > > and sysctl_sched_time_avg includes the attribute const_debug. This > > > attribute

Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-31 Thread Nick Desaulniers
> El Tue, Oct 30, 2017 at 10:57:58AM +0100 Ingo Molnar ha dit: >> So I hate this change, because it pointlessly duplicates an attribute that >> should >> only matter at the definition site. > > It's certainly not ideal, and then again essentially the same is done > in kernel/sched/sched.h, just

Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-31 Thread Nick Desaulniers
> El Tue, Oct 30, 2017 at 10:57:58AM +0100 Ingo Molnar ha dit: >> So I hate this change, because it pointlessly duplicates an attribute that >> should >> only matter at the definition site. > > It's certainly not ideal, and then again essentially the same is done > in kernel/sched/sched.h, just

Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-31 Thread Matthias Kaehlcke
El Tue, Oct 30, 2017 at 10:57:58AM +0100 Ingo Molnar ha dit: > * Matthias Kaehlcke wrote: > > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > and sysctl_sched_time_avg includes the attribute const_debug. This > > attribute is not part of the

Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-31 Thread Matthias Kaehlcke
El Tue, Oct 30, 2017 at 10:57:58AM +0100 Ingo Molnar ha dit: > * Matthias Kaehlcke wrote: > > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > and sysctl_sched_time_avg includes the attribute const_debug. This > > attribute is not part of the extern declaration of

Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-31 Thread Ingo Molnar
* Matthias Kaehlcke wrote: > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > and sysctl_sched_time_avg includes the attribute const_debug. This > attribute is not part of the extern declaration of these variables in > include/linux/sched/sysctl.h, as

Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-31 Thread Ingo Molnar
* Matthias Kaehlcke wrote: > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > and sysctl_sched_time_avg includes the attribute const_debug. This > attribute is not part of the extern declaration of these variables in > include/linux/sched/sysctl.h, as a result clang

[PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-30 Thread Matthias Kaehlcke
The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate and sysctl_sched_time_avg includes the attribute const_debug. This attribute is not part of the extern declaration of these variables in include/linux/sched/sysctl.h, as a result clang generates warnings like this:

[PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-30 Thread Matthias Kaehlcke
The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate and sysctl_sched_time_avg includes the attribute const_debug. This attribute is not part of the extern declaration of these variables in include/linux/sched/sysctl.h, as a result clang generates warnings like this: