Re: [PATCH v2] sched: Remove obscure comment from select_task_rq_fair

2018-05-28 Thread Joel Fernandes
On Mon, May 28, 2018 at 09:15:08AM +0200, Peter Zijlstra wrote: > On Sun, May 27, 2018 at 06:24:47PM -0700, Joel Fernandes (Google) wrote: > > This patch removes the obscure comment which was > > saying this path can be entered only for wake-balance. > > The comment was meant to ask if we want

Re: [PATCH v2] sched: Remove obscure comment from select_task_rq_fair

2018-05-28 Thread Joel Fernandes
On Mon, May 28, 2018 at 09:15:08AM +0200, Peter Zijlstra wrote: > On Sun, May 27, 2018 at 06:24:47PM -0700, Joel Fernandes (Google) wrote: > > This patch removes the obscure comment which was > > saying this path can be entered only for wake-balance. > > The comment was meant to ask if we want

Re: [PATCH v2] sched: Remove obscure comment from select_task_rq_fair

2018-05-28 Thread Peter Zijlstra
On Sun, May 27, 2018 at 06:24:47PM -0700, Joel Fernandes (Google) wrote: > This patch removes the obscure comment which was > saying this path can be entered only for wake-balance. The comment was meant to ask if we want to always do select_idle_siblings() and not only on wakeups.

Re: [PATCH v2] sched: Remove obscure comment from select_task_rq_fair

2018-05-28 Thread Peter Zijlstra
On Sun, May 27, 2018 at 06:24:47PM -0700, Joel Fernandes (Google) wrote: > This patch removes the obscure comment which was > saying this path can be entered only for wake-balance. The comment was meant to ask if we want to always do select_idle_siblings() and not only on wakeups.

[PATCH v2] sched: Remove obscure comment from select_task_rq_fair

2018-05-27 Thread Joel Fernandes (Google)
I was playing with cpusets and sched_load_balance flag and notice that the fast-path (select_idle_sibling) can also be attempted for exec-balance, not just wake-balance if the waker cpu's cpuset has sched_load_balance = 0. This patch removes the obscure comment which was saying this path can be

[PATCH v2] sched: Remove obscure comment from select_task_rq_fair

2018-05-27 Thread Joel Fernandes (Google)
I was playing with cpusets and sched_load_balance flag and notice that the fast-path (select_idle_sibling) can also be attempted for exec-balance, not just wake-balance if the waker cpu's cpuset has sched_load_balance = 0. This patch removes the obscure comment which was saying this path can be