Re: [PATCH v2] scsi: scsi_transport_sas: add missing newline when printing 'enable' by sysfs

2020-07-20 Thread Martin K. Petersen
On Fri, 17 Jul 2020 16:44:32 +0800, Xiongfeng Wang wrote: > When I cat sysfs file 'enable' below 'sas_phy', it displays as follows. > It's better to add a newline for easy reading. > > [root@localhost ~]# cat >

Re: [PATCH v2] scsi: scsi_transport_sas: add missing newline when printing 'enable' by sysfs

2020-07-19 Thread Xiongfeng Wang
Hi, On 2020/7/19 4:25, Bart Van Assche wrote: > On 2020-07-17 01:44, Xiongfeng Wang wrote: >> diff --git a/drivers/scsi/scsi_transport_sas.c >> b/drivers/scsi/scsi_transport_sas.c >> index 182fd25..e443dee 100644 >> --- a/drivers/scsi/scsi_transport_sas.c >> +++

Re: [PATCH v2] scsi: scsi_transport_sas: add missing newline when printing 'enable' by sysfs

2020-07-18 Thread Bart Van Assche
On 2020-07-17 01:44, Xiongfeng Wang wrote: > diff --git a/drivers/scsi/scsi_transport_sas.c > b/drivers/scsi/scsi_transport_sas.c > index 182fd25..e443dee 100644 > --- a/drivers/scsi/scsi_transport_sas.c > +++ b/drivers/scsi/scsi_transport_sas.c > @@ -563,7 +563,7 @@ static ssize_t

[PATCH v2] scsi: scsi_transport_sas: add missing newline when printing 'enable' by sysfs

2020-07-17 Thread Xiongfeng Wang
When I cat sysfs file 'enable' below 'sas_phy', it displays as follows. It's better to add a newline for easy reading. [root@localhost ~]# cat /sys/devices/pci:00/:00:0d.0/:0f:00.0/host3/phy-3:2/sas_phy/phy-3:2/enable 1[root@localhost ~]# Signed-off-by: Xiongfeng Wang Reviewed-by: