Re: [PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-28 Thread Stanimir Varbanov
Hi Doug, On 7/28/20 5:48 PM, Doug Anderson wrote: > Hi, > > On Sun, Jul 26, 2020 at 2:44 AM Stanimir Varbanov > wrote: >> >> Hi Stephen, >> >> On 7/25/20 12:17 AM, Stephen Boyd wrote: >>> From: Stephen Boyd >>> >>> The busy loop in rpmh_rsc_send_data() is written with the assumption >>> that

Re: [PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-28 Thread Doug Anderson
Hi, On Sun, Jul 26, 2020 at 2:44 AM Stanimir Varbanov wrote: > > Hi Stephen, > > On 7/25/20 12:17 AM, Stephen Boyd wrote: > > From: Stephen Boyd > > > > The busy loop in rpmh_rsc_send_data() is written with the assumption > > that the udelay will be preempted by the tcs_tx_done() irq handler

Re: [PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-26 Thread Maulik Shah
Hi, Change looks good to me. Reviewed-by: Maulik Shah Thanks, Maulik On 7/25/2020 2:47 AM, Stephen Boyd wrote: From: Stephen Boyd The busy loop in rpmh_rsc_send_data() is written with the assumption that the udelay will be preempted by the tcs_tx_done() irq handler when the TCS slots are

Re: [PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-26 Thread Stanimir Varbanov
Hi Stephen, On 7/25/20 12:17 AM, Stephen Boyd wrote: > From: Stephen Boyd > > The busy loop in rpmh_rsc_send_data() is written with the assumption > that the udelay will be preempted by the tcs_tx_done() irq handler when > the TCS slots are all full. This doesn't hold true when the calling >

Re: [PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-24 Thread Doug Anderson
Hi, On Fri, Jul 24, 2020 at 2:17 PM Stephen Boyd wrote: > > From: Stephen Boyd > > The busy loop in rpmh_rsc_send_data() is written with the assumption > that the udelay will be preempted by the tcs_tx_done() irq handler when > the TCS slots are all full. This doesn't hold true when the calling

[PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-24 Thread Stephen Boyd
From: Stephen Boyd The busy loop in rpmh_rsc_send_data() is written with the assumption that the udelay will be preempted by the tcs_tx_done() irq handler when the TCS slots are all full. This doesn't hold true when the calling thread is an irqthread and the tcs_tx_done() irq is also an