Hi Dan,
I manually walked through the driver code and spotted the issue. But
this morning I was able to get an extra module to verify my patch on
hardware.
I tested the following patterns using two identical modules, and
checked the creation/destruction/ref_cnt of wm_event:
- insert module A,
Ben, I'm confused. Do you have a way to test this, or are you just
doing manual review?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Ben, I'm confused. Do you have a way to test this, or are you just
doing manual review?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Dan,
I manually walked through the driver code and spotted the issue. But
this morning I was able to get an extra module to verify my patch on
hardware.
I tested the following patterns using two identical modules, and
checked the creation/destruction/ref_cnt of wm_event:
- insert module A,
On Wed, Jul 25, 2012 at 7:23 PM, Ben Chan wrote:
> Hi Devendra,
>
> Thanks for cleaning up the driver. If I understand the code
> correctly, the original author wanted to initialize wm_event once and
> reuse it for multiple devices, and thus reference counted it with
> ref_cnt.
>
> For instance,
On Wed, Jul 25, 2012 at 7:23 PM, Ben Chan benc...@chromium.org wrote:
Hi Devendra,
Thanks for cleaning up the driver. If I understand the code
correctly, the original author wanted to initialize wm_event once and
reuse it for multiple devices, and thus reference counted it with
ref_cnt.
Hi,
Does patch v2 make sense?
Thanks,
Ben
On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan wrote:
> Hi Devendra,
>
> Thanks for cleaning up the driver. If I understand the code
> correctly, the original author wanted to initialize wm_event once and
> reuse it for multiple devices, and thus reference
Hi,
Does patch v2 make sense?
Thanks,
Ben
On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan benc...@chromium.org wrote:
Hi Devendra,
Thanks for cleaning up the driver. If I understand the code
correctly, the original author wanted to initialize wm_event once and
reuse it for multiple devices, and
Hi Devendra,
Thanks for cleaning up the driver. If I understand the code
correctly, the original author wanted to initialize wm_event once and
reuse it for multiple devices, and thus reference counted it with
ref_cnt.
For instance, each time gdm_usb_probe() is called, it may call
Hi Devendra,
Thanks for cleaning up the driver. If I understand the code
correctly, the original author wanted to initialize wm_event once and
reuse it for multiple devices, and thus reference counted it with
ref_cnt.
For instance, each time gdm_usb_probe() is called, it may call
On Tue, Jul 24, 2012 at 8:34 PM, Ben Chan wrote:
> This patch fixes the commit "staging/gdm72xx: cleanup little at
> gdm_wimax_event_rcv" (8df858ea76b76dde9a39d4edd9aaded983582cfe),
> which mishandles the reference counting of wm_event.
>
> Signed-off-by: Ben Chan
> ---
> Fixed the commit
This patch fixes the commit "staging/gdm72xx: cleanup little at
gdm_wimax_event_rcv" (8df858ea76b76dde9a39d4edd9aaded983582cfe),
which mishandles the reference counting of wm_event.
Signed-off-by: Ben Chan
---
Fixed the commit message as suggested by Dan Carpenter.
This patch fixes the commit staging/gdm72xx: cleanup little at
gdm_wimax_event_rcv (8df858ea76b76dde9a39d4edd9aaded983582cfe),
which mishandles the reference counting of wm_event.
Signed-off-by: Ben Chan benc...@chromium.org
---
Fixed the commit message as suggested by Dan Carpenter.
On Tue, Jul 24, 2012 at 8:34 PM, Ben Chan benc...@chromium.org wrote:
This patch fixes the commit staging/gdm72xx: cleanup little at
gdm_wimax_event_rcv (8df858ea76b76dde9a39d4edd9aaded983582cfe),
which mishandles the reference counting of wm_event.
Signed-off-by: Ben Chan
14 matches
Mail list logo
