Re: [PATCH v2] staging: goldfish: Fix style issues in macros

2017-03-27 Thread aviyae
I'll remove that eudyptula thing, although there are some patches that mention it (run git log --grep=eudyptula) On 27/03/17 15:05, Frans Klaver wrote: > On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote: >> From: Aviya Erenfeld >> >> staging: goldfish:

Re: [PATCH v2] staging: goldfish: Fix style issues in macros

2017-03-27 Thread aviyae
I'll remove that eudyptula thing, although there are some patches that mention it (run git log --grep=eudyptula) On 27/03/17 15:05, Frans Klaver wrote: > On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote: >> From: Aviya Erenfeld >> >> staging: goldfish: Fix style issues in macros >> >> Fix

Re: [PATCH v2] staging: goldfish: Fix style issues in macros

2017-03-27 Thread Frans Klaver
On Mon, Mar 27, 2017 at 2:13 PM, aviyae wrote: > I'll remove that eudyptula thing, although there are some patches that > mention it > > (run git log --grep=eudyptula) I haven't checked that and I think it's a shame it didn't get removed. I don't think it adds value to the

Re: [PATCH v2] staging: goldfish: Fix style issues in macros

2017-03-27 Thread Frans Klaver
On Mon, Mar 27, 2017 at 2:13 PM, aviyae wrote: > I'll remove that eudyptula thing, although there are some patches that > mention it > > (run git log --grep=eudyptula) I haven't checked that and I think it's a shame it didn't get removed. I don't think it adds value to the patch, as it's just

Re: [PATCH v2] staging: goldfish: Fix style issues in macros

2017-03-27 Thread Frans Klaver
On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote: > From: Aviya Erenfeld > > staging: goldfish: Fix style issues in macros > > Fix coding style issues in macros: > 1. Add parenthesis around macros argument > 2. Avoid arguments reuse in macros > > (For the

Re: [PATCH v2] staging: goldfish: Fix style issues in macros

2017-03-27 Thread Frans Klaver
On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote: > From: Aviya Erenfeld > > staging: goldfish: Fix style issues in macros > > Fix coding style issues in macros: > 1. Add parenthesis around macros argument > 2. Avoid arguments reuse in macros > > (For the eudyptula challenge) How is that relevant?

[PATCH v2] staging: goldfish: Fix style issues in macros

2017-03-27 Thread aviyae
From: Aviya Erenfeld staging: goldfish: Fix style issues in macros Fix coding style issues in macros: 1. Add parenthesis around macros argument 2. Avoid arguments reuse in macros (For the eudyptula challenge) Signed-off-by: Aviya Erenfeld ---

[PATCH v2] staging: goldfish: Fix style issues in macros

2017-03-27 Thread aviyae
From: Aviya Erenfeld staging: goldfish: Fix style issues in macros Fix coding style issues in macros: 1. Add parenthesis around macros argument 2. Avoid arguments reuse in macros (For the eudyptula challenge) Signed-off-by: Aviya Erenfeld --- drivers/staging/goldfish/goldfish_audio.c | 8