Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

2019-01-07 Thread Július Milan
On Mon, Jan 07, 2019 at 06:06:55AM +, ajay.kat...@microchip.com wrote: Hi Ajay, > Please resubmit the patch by changing 'frame_type' type to '__le16' in > 'wilc_reg_frame' struct. Done, sent patch version 4. Message subject changed to: "[PATCH v4] staging: wilc1000: fix registration frame

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

2019-01-06 Thread Ajay.Kathat
Hi Julius, On 1/6/2019 12:48 PM, Július Milan wrote: >> Before you send V3, are you sure this is the correct fix? As "frame_type" is >> input as u16, it seems to me that the frame_type member of struct >> wilc_reg_frame >> should be __le16, not __le32. > > Yes, I am confident about it. > The

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

2019-01-05 Thread Július Milan
Thank you for your review Larry > Before you send V3 Oh, v3 was already sent a few moments before your message. > Before you send V3, are you sure this is the correct fix? As "frame_type" is > input as u16, it seems to me that the frame_type member of struct > wilc_reg_frame > should be

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

2019-01-05 Thread Larry Finger
On 1/5/19 3:10 AM, Július Milan wrote: Fixes the following sparse warnings: drivers/staging/wilc1000/host_interface.c:2360:30: warning: incorrect type in assignment (different base types) expected restricted __le32 [addressable] [assigned] [usertype] frame_type got restricted __le16

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

2019-01-05 Thread Greg KH
On Sat, Jan 05, 2019 at 10:10:25AM +0100, Július Milan wrote: > Fixes the following sparse warnings: > > drivers/staging/wilc1000/host_interface.c:2360:30: warning: > incorrect type in assignment (different base types) > expected restricted __le32 [addressable] [assigned] [usertype]

[PATCH v2] staging: wilc1000: fix cast to restricted __le32

2019-01-05 Thread Július Milan
Fixes the following sparse warnings: drivers/staging/wilc1000/host_interface.c:2360:30: warning: incorrect type in assignment (different base types) expected restricted __le32 [addressable] [assigned] [usertype] frame_type got restricted __le16 [usertype] Fixes: 147ccfd451024