Re: [PATCH v2] staging: xgifb: remove macros with hidden variable

2017-12-01 Thread Josh Abraham
On Fri, Dec 01, 2017 at 10:12:30AM +0300, Dan Carpenter wrote: > On Thu, Nov 30, 2017 at 10:39:48AM -0500, Joshua Abraham wrote: > > diff --git a/drivers/staging/xgifb/XGI_main_26.c > > b/drivers/staging/xgifb/XGI_main_26.c > > index 6feecc55d2bc..6de66eaad96b 100644 > > ---

Re: [PATCH v2] staging: xgifb: remove macros with hidden variable

2017-12-01 Thread Josh Abraham
On Fri, Dec 01, 2017 at 10:12:30AM +0300, Dan Carpenter wrote: > On Thu, Nov 30, 2017 at 10:39:48AM -0500, Joshua Abraham wrote: > > diff --git a/drivers/staging/xgifb/XGI_main_26.c > > b/drivers/staging/xgifb/XGI_main_26.c > > index 6feecc55d2bc..6de66eaad96b 100644 > > ---

Re: [PATCH v2] staging: xgifb: remove macros with hidden variable

2017-11-30 Thread Dan Carpenter
On Thu, Nov 30, 2017 at 10:39:48AM -0500, Joshua Abraham wrote: > diff --git a/drivers/staging/xgifb/XGI_main_26.c > b/drivers/staging/xgifb/XGI_main_26.c > index 6feecc55d2bc..6de66eaad96b 100644 > --- a/drivers/staging/xgifb/XGI_main_26.c > +++ b/drivers/staging/xgifb/XGI_main_26.c > @@ -34,16

Re: [PATCH v2] staging: xgifb: remove macros with hidden variable

2017-11-30 Thread Dan Carpenter
On Thu, Nov 30, 2017 at 10:39:48AM -0500, Joshua Abraham wrote: > diff --git a/drivers/staging/xgifb/XGI_main_26.c > b/drivers/staging/xgifb/XGI_main_26.c > index 6feecc55d2bc..6de66eaad96b 100644 > --- a/drivers/staging/xgifb/XGI_main_26.c > +++ b/drivers/staging/xgifb/XGI_main_26.c > @@ -34,16

[PATCH v2] staging: xgifb: remove macros with hidden variable

2017-11-30 Thread Joshua Abraham
This patch removes macros in XGI_main.h that contain a xgifb_info variable. These macros hurt readability by hiding said variable behind a define. Signed-off-by: Joshua Abraham --- drivers/staging/xgifb/XGI_main.h| 13 --- drivers/staging/xgifb/XGI_main_26.c | 227

[PATCH v2] staging: xgifb: remove macros with hidden variable

2017-11-30 Thread Joshua Abraham
This patch removes macros in XGI_main.h that contain a xgifb_info variable. These macros hurt readability by hiding said variable behind a define. Signed-off-by: Joshua Abraham --- drivers/staging/xgifb/XGI_main.h| 13 --- drivers/staging/xgifb/XGI_main_26.c | 227