Re: [PATCH v2] tipc: ensure head->lock is initialised

2019-07-12 Thread David Miller
From: Chris Packham Date: Fri, 12 Jul 2019 10:41:15 +1200 > tipc_named_node_up() creates a skb list. It passes the list to > tipc_node_xmit() which has some code paths that can call > skb_queue_purge() which relies on the list->lock being initialised. > > The spin_lock is only needed if the mess

RE: [PATCH v2] tipc: ensure head->lock is initialised

2019-07-12 Thread Jon Maloy
gt; ying@windriver.com; da...@davemloft.net > Cc: linux-kernel@vger.kernel.org; net...@vger.kernel.org; tipc- > discuss...@lists.sourceforge.net; Chris Packham > > Subject: [PATCH v2] tipc: ensure head->lock is initialised > > tipc_named_node_up() creates a skb list. It passes

[PATCH v2] tipc: ensure head->lock is initialised

2019-07-11 Thread Chris Packham
tipc_named_node_up() creates a skb list. It passes the list to tipc_node_xmit() which has some code paths that can call skb_queue_purge() which relies on the list->lock being initialised. The spin_lock is only needed if the messages end up on the receive path but when the list is created in tipc_n