Re: [PATCH v2] trace: tracing_event_filter: fast path when no subsystem filters

2023-11-22 Thread Steven Rostedt
On Thu, 12 Oct 2023 16:37:35 -0400 Nick Lowell wrote: Sorry, I was traveling when this was sent, and I missed it. > I really appreciate the continued feedback. I was able to reproduce. > I think I'm understanding better but still need some help. > I am actually wondering if

Re: [PATCH v2] trace: tracing_event_filter: fast path when no subsystem filters

2023-10-12 Thread Nick Lowell
On Wed, Oct 4, 2023 at 10:52 AM Steven Rostedt wrote: > > On Wed, 4 Oct 2023 10:39:33 -0400 > Nick Lowell wrote: > > > > [ cut here ] > > > WARNING: CPU: 5 PID: 944 at kernel/trace/trace_events_filter.c:2423 > > > apply_subsystem_event_filter+0x18c/0x5e0 > > > Modules

Re: [PATCH v2] trace: tracing_event_filter: fast path when no subsystem filters

2023-10-04 Thread Steven Rostedt
On Wed, 4 Oct 2023 10:39:33 -0400 Nick Lowell wrote: > > [ cut here ] > > WARNING: CPU: 5 PID: 944 at kernel/trace/trace_events_filter.c:2423 > > apply_subsystem_event_filter+0x18c/0x5e0 > > Modules linked in: > > CPU: 5 PID: 944 Comm: trace-cmd Not tainted > >

Re: [PATCH v2] trace: tracing_event_filter: fast path when no subsystem filters

2023-10-04 Thread Nick Lowell
On Tue, Oct 3, 2023 at 10:29 PM Steven Rostedt wrote: > > On Mon, 2 Oct 2023 10:41:48 -0400 > Nicholas Lowell wrote: > > > @@ -2411,7 +2418,12 @@ int apply_subsystem_event_filter(struct > > trace_subsystem_dir *dir, > > } > > > > if (!strcmp(strstrip(filter_string), "0")) { > > -

Re: [PATCH v2] trace: tracing_event_filter: fast path when no subsystem filters

2023-10-03 Thread Steven Rostedt
On Mon, 2 Oct 2023 10:41:48 -0400 Nicholas Lowell wrote: > @@ -2411,7 +2418,12 @@ int apply_subsystem_event_filter(struct > trace_subsystem_dir *dir, > } > > if (!strcmp(strstrip(filter_string), "0")) { > - filter_free_subsystem_preds(dir, tr); > + /* If

[PATCH v2] trace: tracing_event_filter: fast path when no subsystem filters

2023-10-02 Thread Nicholas Lowell
From: Nicholas Lowell If there are no filters in the event subsystem, then there's no reason to continue and hit the potentially time consuming tracepoint_synchronize_unregister function. This should give a speed up for initial disabling/configuring Signed-off-by: Nicholas Lowell --- Notes: