Re: [PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-12 Thread Pramod Gurav
Hi Stephen, On Friday 09 January 2015 03:16 AM, Stephen Boyd wrote: > On 01/08/2015 01:15 AM, Pramod Gurav wrote: >> drivers/tty/serial/msm_serial.c | 15 --- >> 1 file changed, 15 deletions(-) >> >> diff --git a/drivers/tty/serial/msm_serial.c >> b/drivers/tty/serial/msm_serial.c

Re: [PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-12 Thread Pramod Gurav
Hi Stephen, On Friday 09 January 2015 03:16 AM, Stephen Boyd wrote: On 01/08/2015 01:15 AM, Pramod Gurav wrote: drivers/tty/serial/msm_serial.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index

Re: [PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-08 Thread Pramod Gurav
Hi Stephen, On Friday 09 January 2015 03:16 AM, Stephen Boyd wrote: > On 01/08/2015 01:15 AM, Pramod Gurav wrote: >> drivers/tty/serial/msm_serial.c | 15 --- >> 1 file changed, 15 deletions(-) >> >> diff --git a/drivers/tty/serial/msm_serial.c >> b/drivers/tty/serial/msm_serial.c

Re: [PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-08 Thread Stephen Boyd
On 01/08/2015 01:15 AM, Pramod Gurav wrote: > drivers/tty/serial/msm_serial.c | 15 --- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c > index c88b522..057008d 100644 > --- a/drivers/tty/serial/msm_serial.c > +++

[PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-08 Thread Pramod Gurav
The changes done here are already being done somewhere else in code. - The function msm_init_clock() is also called while doing msm_startup hence removing. - msm_set_baud_rate() is anyway called in uart_set_options when it calls msm_set_termios(). msm_reset() is called when we change the

Re: [PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-08 Thread Pramod Gurav
Hi Stephen, On Friday 09 January 2015 03:16 AM, Stephen Boyd wrote: On 01/08/2015 01:15 AM, Pramod Gurav wrote: drivers/tty/serial/msm_serial.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index

Re: [PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-08 Thread Stephen Boyd
On 01/08/2015 01:15 AM, Pramod Gurav wrote: drivers/tty/serial/msm_serial.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index c88b522..057008d 100644 --- a/drivers/tty/serial/msm_serial.c +++

[PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-08 Thread Pramod Gurav
The changes done here are already being done somewhere else in code. - The function msm_init_clock() is also called while doing msm_startup hence removing. - msm_set_baud_rate() is anyway called in uart_set_options when it calls msm_set_termios(). msm_reset() is called when we change the