Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-23 Thread Prashant Malani
On Thu, Oct 22, 2020 at 12:13 AM Prashant Malani wrote: > > Thanks for reviewing the patch, Greg. > > On Wed, Oct 21, 2020 at 11:56 PM Greg KH wrote: > > > > > > > > +What: > > > /sys/class/typec/-cable/identity/product_type_vdo > > > +Date:October 2020 > > >

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-23 Thread Heikki Krogerus
On Thu, Oct 22, 2020 at 04:25:23PM -0700, Benson Leung wrote: > Hi Heikki, > > On Thu, Oct 22, 2020 at 5:43 AM Heikki Krogerus > wrote: > > > > On Thu, Oct 22, 2020 at 12:25:07AM -0700, Prashant Malani wrote: > > > Hi Greg, > > > > > > On Thu, Oct 22, 2020 at 12:17 AM Greg KH > > > wrote: > >

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-22 Thread Benson Leung
Hi Heikki, On Thu, Oct 22, 2020 at 5:43 AM Heikki Krogerus wrote: > > On Thu, Oct 22, 2020 at 12:25:07AM -0700, Prashant Malani wrote: > > Hi Greg, > > > > On Thu, Oct 22, 2020 at 12:17 AM Greg KH wrote: > > > > > > > > > +What: > > > > > >

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-22 Thread Prashant Malani
Hi Heikki, Thanks for your feedback. On Thu, Oct 22, 2020 at 5:43 AM Heikki Krogerus wrote: > > On Thu, Oct 22, 2020 at 12:25:07AM -0700, Prashant Malani wrote: > > Hi Greg, > > > > On Thu, Oct 22, 2020 at 12:17 AM Greg KH wrote: > > > > > > Given that your current implementation is not

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-22 Thread Heikki Krogerus
On Thu, Oct 22, 2020 at 12:25:07AM -0700, Prashant Malani wrote: > Hi Greg, > > On Thu, Oct 22, 2020 at 12:17 AM Greg KH wrote: > > > > > > > +What: > > > > > /sys/class/typec/-partner/identity/product_type_vdo > > > > > +Date:October 2020 > > > > > +Contact:

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-22 Thread Prashant Malani
Hi Greg, On Thu, Oct 22, 2020 at 12:17 AM Greg KH wrote: > > > > > +What: > > > > /sys/class/typec/-partner/identity/product_type_vdo > > > > +Date:October 2020 > > > > +Contact: Prashant Malani > > > > +Description: > > > > + Product Type VDOs

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 12:13:54AM -0700, Prashant Malani wrote: > Thanks for reviewing the patch, Greg. > > On Wed, Oct 21, 2020 at 11:56 PM Greg KH wrote: > > > > On Wed, Oct 21, 2020 at 11:15:54PM -0700, Prashant Malani wrote: > > > > > > diff --git

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-22 Thread Prashant Malani
Thanks for reviewing the patch, Greg. On Wed, Oct 21, 2020 at 11:56 PM Greg KH wrote: > > On Wed, Oct 21, 2020 at 11:15:54PM -0700, Prashant Malani wrote: > > > > diff --git a/Documentation/ABI/testing/sysfs-class-typec > > b/Documentation/ABI/testing/sysfs-class-typec > > index

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-22 Thread Greg KH
On Wed, Oct 21, 2020 at 11:15:54PM -0700, Prashant Malani wrote: > A PD-capable device can return up to 3 Product Type VDOs as part of its > DiscoverIdentity Response (USB PD Spec, Rev 3.0, Version 2.0, Section > 6.4.4.3.1). Add a sysfs attribute to expose these to userspace. > > Cc: Benson Leung

[PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

2020-10-22 Thread Prashant Malani
A PD-capable device can return up to 3 Product Type VDOs as part of its DiscoverIdentity Response (USB PD Spec, Rev 3.0, Version 2.0, Section 6.4.4.3.1). Add a sysfs attribute to expose these to userspace. Cc: Benson Leung Cc: Heikki Krogerus Signed-off-by: Prashant Malani --- NOTE: I didn't