Re: [PATCH v2] vfs: constify arguments to utime family of system calls

2016-03-31 Thread Al Viro
On Thu, Mar 31, 2016 at 09:24:57PM -0500, Eric Biggers wrote: > I feel it's a small improvement as it reduces the chance of bugs. However, if > you look at all the system calls, they are, in general, inconsistent about > using > 'const'. So may be right that changing just a few isn't worthwhile

Re: [PATCH v2] vfs: constify arguments to utime family of system calls

2016-03-31 Thread Eric Biggers
On Fri, Apr 01, 2016 at 03:05:24AM +0100, Al Viro wrote: > On Thu, Mar 31, 2016 at 08:51:12PM -0500, Eric Biggers wrote: > > The system calls to set file times: utime(), utimes(), futimesat(), and > > utimensat(), all take in pointers to a filename and time information, > > neither of which is modi

Re: [PATCH v2] vfs: constify arguments to utime family of system calls

2016-03-31 Thread Al Viro
On Thu, Mar 31, 2016 at 08:51:12PM -0500, Eric Biggers wrote: > The system calls to set file times: utime(), utimes(), futimesat(), and > utimensat(), all take in pointers to a filename and time information, > neither of which is modified. Mark the pointed-to data as 'const' to > better reflect th

[PATCH v2] vfs: constify arguments to utime family of system calls

2016-03-31 Thread Eric Biggers
The system calls to set file times: utime(), utimes(), futimesat(), and utimensat(), all take in pointers to a filename and time information, neither of which is modified. Mark the pointed-to data as 'const' to better reflect the semantics. Signed-off-by: Eric Biggers --- arch/alpha/kernel/osf_