RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
> -Original Message- > > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > > Sent: Tuesday, July 8, 2014 17:27 PM > > > To: Dexuan Cui > > > Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; > driverdev- > > > de...@linuxdriverproject.org; plagn...@jcrosoft.com; > > >

Re: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread gre...@linuxfoundation.org
On Tue, Jul 08, 2014 at 10:17:48PM +, Dexuan Cui wrote: > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Tuesday, July 8, 2014 17:27 PM > > To: Dexuan Cui > > Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- > >

RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday, July 8, 2014 17:27 PM > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; plagn...@jcrosoft.com; > tomi.valkei...@ti.com;

Re: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dan Carpenter
Don't use likely/unlikely unless you have benchmark numbers to show that it makes a speed up. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
> -Original Message- > From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev- > devel-boun...@linuxdriverproject.org] On Behalf Of Dexuan Cui > Sent: Friday, June 27, 2014 5:35 AM > To: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- >

RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
-Original Message- From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev- devel-boun...@linuxdriverproject.org] On Behalf Of Dexuan Cui Sent: Friday, June 27, 2014 5:35 AM To: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev-

Re: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dan Carpenter
Don't use likely/unlikely unless you have benchmark numbers to show that it makes a speed up. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Tuesday, July 8, 2014 17:27 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- de...@linuxdriverproject.org; plagn...@jcrosoft.com; tomi.valkei...@ti.com;

Re: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread gre...@linuxfoundation.org
On Tue, Jul 08, 2014 at 10:17:48PM +, Dexuan Cui wrote: -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Tuesday, July 8, 2014 17:27 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev-

RE: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-08 Thread Dexuan Cui
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Tuesday, July 8, 2014 17:27 PM To: Dexuan Cui Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- de...@linuxdriverproject.org; plagn...@jcrosoft.com;

[PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-06-26 Thread Dexuan Cui
Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM panic because the notification work is done in a workqueue, and in panic() the kernel typically ends up in an infinite loop, and a typical kernel config has CONFIG_PREEMPT_VOLUNTARY=y and CONFIG_PREEMPT is not set, so a

[PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-06-26 Thread Dexuan Cui
Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM panic because the notification work is done in a workqueue, and in panic() the kernel typically ends up in an infinite loop, and a typical kernel config has CONFIG_PREEMPT_VOLUNTARY=y and CONFIG_PREEMPT is not set, so a