Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Martin Kelly
On 10/21/2014 12:44 PM, Thomas Gleixner wrote: > On Tue, 21 Oct 2014, Martin Kelly wrote: >> On 10/21/2014 01:56 AM, Thomas Gleixner wrote: >> Thomas, do you see any issues with a revision that separates out the >> return values (0 for a map with 1 entry, -1 for a map with invalid >> entries) and

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Thomas Gleixner
On Tue, 21 Oct 2014, Martin Kelly wrote: > On 10/21/2014 01:56 AM, Thomas Gleixner wrote: > >> This patch changes the behavior so that sanitize_e820_map is a void > >> function. When the provided memory map has length 1 or it is sanitized > >> (both ok cases), it returns nothing. If the provided

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Martin Kelly
On 10/21/2014 01:56 AM, Thomas Gleixner wrote: >> This patch changes the behavior so that sanitize_e820_map is a void >> function. When the provided memory map has length 1 or it is sanitized >> (both ok cases), it returns nothing. If the provided memory map is >> invalid, then it panics. > > So

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Thomas Gleixner
On Mon, 20 Oct 2014, Martin Kelly wrote: > sanitize_e820_map returns two possible values: > -1: Returned when either the provided memory map has length 1 (ok) or > when the provided memory map is invalid (not ok). > 0: Returned when the memory map was correctly sanitized. > > In addition,

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Thomas Gleixner
On Mon, 20 Oct 2014, Martin Kelly wrote: sanitize_e820_map returns two possible values: -1: Returned when either the provided memory map has length 1 (ok) or when the provided memory map is invalid (not ok). 0: Returned when the memory map was correctly sanitized. In addition, most

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Martin Kelly
On 10/21/2014 01:56 AM, Thomas Gleixner wrote: This patch changes the behavior so that sanitize_e820_map is a void function. When the provided memory map has length 1 or it is sanitized (both ok cases), it returns nothing. If the provided memory map is invalid, then it panics. So you break

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Thomas Gleixner
On Tue, 21 Oct 2014, Martin Kelly wrote: On 10/21/2014 01:56 AM, Thomas Gleixner wrote: This patch changes the behavior so that sanitize_e820_map is a void function. When the provided memory map has length 1 or it is sanitized (both ok cases), it returns nothing. If the provided memory map

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Martin Kelly
On 10/21/2014 12:44 PM, Thomas Gleixner wrote: On Tue, 21 Oct 2014, Martin Kelly wrote: On 10/21/2014 01:56 AM, Thomas Gleixner wrote: Thomas, do you see any issues with a revision that separates out the return values (0 for a map with 1 entry, -1 for a map with invalid entries) and adds

[PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-20 Thread Martin Kelly
sanitize_e820_map returns two possible values: -1: Returned when either the provided memory map has length 1 (ok) or when the provided memory map is invalid (not ok). 0: Returned when the memory map was correctly sanitized. In addition, most code ignores the returned value, and none actually

[PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-20 Thread Martin Kelly
sanitize_e820_map returns two possible values: -1: Returned when either the provided memory map has length 1 (ok) or when the provided memory map is invalid (not ok). 0: Returned when the memory map was correctly sanitized. In addition, most code ignores the returned value, and none actually