Re: [PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-06 Thread Ingo Molnar
* Alexander Potapenko wrote: > On Fri, Apr 5, 2019 at 11:39 AM Ingo Molnar wrote: > > > > > > * Alexander Potapenko wrote: > > > > > 1. Use memory clobber in bitops that touch arbitrary memory > > > > > > Certain bit operations that read/write bits take a base pointer and an > > >

Re: [PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-05 Thread Alexander Potapenko
On Fri, Apr 5, 2019 at 11:39 AM Ingo Molnar wrote: > > > * Alexander Potapenko wrote: > > > 1. Use memory clobber in bitops that touch arbitrary memory > > > > Certain bit operations that read/write bits take a base pointer and an > > arbitrarily large offset to address the bit relative to that

RE: [PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-05 Thread David Laight
From: Ingo Molnar > Sent: 05 April 2019 10:40 > > * Alexander Potapenko wrote: > > > 1. Use memory clobber in bitops that touch arbitrary memory > > > > Certain bit operations that read/write bits take a base pointer and an > > arbitrarily large offset to address the bit relative to that base.

Re: [PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-05 Thread Ingo Molnar
* Alexander Potapenko wrote: > 1. Use memory clobber in bitops that touch arbitrary memory > > Certain bit operations that read/write bits take a base pointer and an > arbitrarily large offset to address the bit relative to that base. > Inline assembly constraints aren't expressive enough to

Re: [PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-02 Thread Alexander Potapenko
On Tue, Apr 2, 2019 at 2:35 PM Alexander Potapenko wrote: > > On Tue, Apr 2, 2019 at 1:44 PM David Laight wrote: > > > > From: Alexander Potapenko > > > Sent: 02 April 2019 12:28 > > > > > > 1. Use memory clobber in bitops that touch arbitrary memory > > > > > > Certain bit operations that

Re: [PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-02 Thread Alexander Potapenko
On Tue, Apr 2, 2019 at 1:44 PM David Laight wrote: > > From: Alexander Potapenko > > Sent: 02 April 2019 12:28 > > > > 1. Use memory clobber in bitops that touch arbitrary memory > > > > Certain bit operations that read/write bits take a base pointer and an > > arbitrarily large offset to address

RE: [PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-02 Thread David Laight
From: Alexander Potapenko > Sent: 02 April 2019 12:28 > > 1. Use memory clobber in bitops that touch arbitrary memory > > Certain bit operations that read/write bits take a base pointer and an > arbitrarily large offset to address the bit relative to that base. Although x86_64 can use a signed

Re: [PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-02 Thread Alexander Potapenko
On Tue, Apr 2, 2019 at 1:28 PM Alexander Potapenko wrote: > > 1. Use memory clobber in bitops that touch arbitrary memory > > Certain bit operations that read/write bits take a base pointer and an > arbitrarily large offset to address the bit relative to that base. > Inline assembly constraints

[PATCH v2] x86/asm: fix assembly constraints in bitops

2019-04-02 Thread Alexander Potapenko
1. Use memory clobber in bitops that touch arbitrary memory Certain bit operations that read/write bits take a base pointer and an arbitrarily large offset to address the bit relative to that base. Inline assembly constraints aren't expressive enough to tell the compiler that the assembly