Re: [PATCH v2] x86/boot: Use EFI setup data if provided

2019-03-29 Thread Chao Fan
On Fri, Mar 29, 2019 at 09:37:00AM +, Junichi Nomura wrote: >On 3/29/19 6:16 PM, Borislav Petkov wrote: >> On Fri, Mar 29, 2019 at 05:05:50PM +0800, Chao Fan wrote: >>> But in my code, I am not sure which version will be found firstly, so I >>> write this logical, if ACPI20 found, return

Re: [PATCH v2] x86/boot: Use EFI setup data if provided

2019-03-26 Thread b...@redhat.com
Hi Junichi, On 03/26/19 at 02:57pm, Borislav Petkov wrote: > On Mon, Mar 25, 2019 at 11:10:01PM +, Junichi Nomura wrote: > > efi_get_rsdp_addr() and kexec_get_rsdp_addr() could be implemented > > like this (sorry about the pseudo code): > > This doesn't look like what I suggested: > > > So

Re: [PATCH v2] x86/boot: Use EFI setup data if provided

2019-03-26 Thread Borislav Petkov
On Mon, Mar 25, 2019 at 11:10:01PM +, Junichi Nomura wrote: > efi_get_rsdp_addr() and kexec_get_rsdp_addr() could be implemented > like this (sorry about the pseudo code): This doesn't look like what I suggested: > So efi_get_rsdp_addr() needs to be refactored in such a way so that at >

Re: [PATCH v2] x86/boot: Use EFI setup data if provided

2019-03-25 Thread Dave Young
On 03/25/19 at 09:54am, Boris Petkov wrote: > On March 25, 2019 9:27:21 AM GMT+01:00, Junichi Nomura > wrote: > >On 3/25/19 3:59 PM, Dave Young wrote: > >> On 03/25/19 at 06:47am, Junichi Nomura wrote: > >>> On 3/25/19 3:19 PM, Dave Young wrote: > On 03/25/19 at 02:01pm, Dave Young wrote: >