Re: [PATCH v2] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Yinghai Lu
On Mon, May 1, 2017 at 12:32 PM, Ingo Molnar wrote: > > * Baoquan He wrote: > >> arch/x86/mm/init_64.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c >> index 15173d3..dfa9edb 100644 >> --- a/arch/x86/mm/init_64.c >> +

Re: [PATCH v2] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Ingo Molnar
* Baoquan He wrote: > arch/x86/mm/init_64.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index 15173d3..dfa9edb 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -96,7 +96,9 @@ void sync_global

Re: [PATCH v2] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 8:55 AM, Baoquan He wrote: > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' > won't. > > This is bec

[PATCH v2] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Baoquan He
Jeff Moyer reported that on his system with two memory regions 0~64G and 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr will make system hang intermittently during boot. While adding 'nokaslr' won't. This is because the for loop count calculation in sync_global_pgds is not