Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Toshi Kani
On Tue, 2016-03-08 at 15:31 -0800, Linus Torvalds wrote: > On Tue, Mar 8, 2016 at 4:04 PM, Toshi Kani wrote: > > > > Yes, I prefer the devm semantics.  insert_resource() and > > remove_resource() are not exported interfaces.  So, with > > devm_add_action(), we still need to

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Toshi Kani
On Tue, 2016-03-08 at 15:31 -0800, Linus Torvalds wrote: > On Tue, Mar 8, 2016 at 4:04 PM, Toshi Kani wrote: > > > > Yes, I prefer the devm semantics.  insert_resource() and > > remove_resource() are not exported interfaces.  So, with > > devm_add_action(), we still need to introduce built-in

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Linus Torvalds
On Tue, Mar 8, 2016 at 4:04 PM, Toshi Kani wrote: > > Yes, I prefer the devm semantics. insert_resource() and remove_resource() > are not exported interfaces. So, with devm_add_action(), we still need to > introduce built-in exported wrappers for insert/remove_resource(),

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Linus Torvalds
On Tue, Mar 8, 2016 at 4:04 PM, Toshi Kani wrote: > > Yes, I prefer the devm semantics. insert_resource() and remove_resource() > are not exported interfaces. So, with devm_add_action(), we still need to > introduce built-in exported wrappers for insert/remove_resource(), unless > we change to

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Toshi Kani
On Tue, 2016-03-08 at 14:44 -0800, Dan Williams wrote: > On Tue, Mar 8, 2016 at 2:23 PM, Linus Torvalds > wrote: > > On Tue, Mar 8, 2016 at 12:59 PM, Dan Williams > > wrote: > > > > > > Here's the usage patch from Toshi [1] (copied

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Toshi Kani
On Tue, 2016-03-08 at 14:44 -0800, Dan Williams wrote: > On Tue, Mar 8, 2016 at 2:23 PM, Linus Torvalds > wrote: > > On Tue, Mar 8, 2016 at 12:59 PM, Dan Williams > > wrote: > > > > > > Here's the usage patch from Toshi [1] (copied below).  It is indeed a > > > resource injected by nfit /

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Dan Williams
On Tue, Mar 8, 2016 at 2:23 PM, Linus Torvalds wrote: > On Tue, Mar 8, 2016 at 12:59 PM, Dan Williams > wrote: >> >> Here's the usage patch from Toshi [1] (copied below). It is indeed a >> resource injected by nfit / nvdimm bus

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Dan Williams
On Tue, Mar 8, 2016 at 2:23 PM, Linus Torvalds wrote: > On Tue, Mar 8, 2016 at 12:59 PM, Dan Williams > wrote: >> >> Here's the usage patch from Toshi [1] (copied below). It is indeed a >> resource injected by nfit / nvdimm bus implementation. We just happen >> to support nfit and libnvdimm

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Linus Torvalds
On Tue, Mar 8, 2016 at 12:59 PM, Dan Williams wrote: > > Here's the usage patch from Toshi [1] (copied below). It is indeed a > resource injected by nfit / nvdimm bus implementation. We just happen > to support nfit and libnvdimm as modules. > > The goal of these

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Linus Torvalds
On Tue, Mar 8, 2016 at 12:59 PM, Dan Williams wrote: > > Here's the usage patch from Toshi [1] (copied below). It is indeed a > resource injected by nfit / nvdimm bus implementation. We just happen > to support nfit and libnvdimm as modules. > > The goal of these patches is to use the ACPI NFIT

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Dan Williams
On Tue, Mar 8, 2016 at 12:05 PM, Linus Torvalds wrote: > On Tue, Mar 8, 2016 at 10:08 AM, Toshi Kani wrote: >> >> Add device-managed implementaions of insert_resource() and >> remove_resouce() functions. > > Can we get an example of the users

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Dan Williams
On Tue, Mar 8, 2016 at 12:05 PM, Linus Torvalds wrote: > On Tue, Mar 8, 2016 at 10:08 AM, Toshi Kani wrote: >> >> Add device-managed implementaions of insert_resource() and >> remove_resouce() functions. > > Can we get an example of the users and show how much this would actually help? > >

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Linus Torvalds
On Tue, Mar 8, 2016 at 10:08 AM, Toshi Kani wrote: > > Add device-managed implementaions of insert_resource() and > remove_resouce() functions. Can we get an example of the users and show how much this would actually help? insert_resource() is fairly unusual to begin with,

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Linus Torvalds
On Tue, Mar 8, 2016 at 10:08 AM, Toshi Kani wrote: > > Add device-managed implementaions of insert_resource() and > remove_resouce() functions. Can we get an example of the users and show how much this would actually help? insert_resource() is fairly unusual to begin with, and it should

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Ingo Molnar
* Toshi Kani wrote: > insert_resource() and remove_resouce() are called by producers > of resources, such as FW modules and bus drivers. These modules > may be implemented as loadable modules. > > Add device-managed implementaions of insert_resource() and >

Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Ingo Molnar
* Toshi Kani wrote: > insert_resource() and remove_resouce() are called by producers > of resources, such as FW modules and bus drivers. These modules > may be implemented as loadable modules. > > Add device-managed implementaions of insert_resource() and > remove_resouce() functions. > >

[PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Toshi Kani
insert_resource() and remove_resouce() are called by producers of resources, such as FW modules and bus drivers. These modules may be implemented as loadable modules. Add device-managed implementaions of insert_resource() and remove_resouce() functions. Signed-off-by: Toshi Kani

[PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource()

2016-03-08 Thread Toshi Kani
insert_resource() and remove_resouce() are called by producers of resources, such as FW modules and bus drivers. These modules may be implemented as loadable modules. Add device-managed implementaions of insert_resource() and remove_resouce() functions. Signed-off-by: Toshi Kani Cc: Ingo