Re: [PATCH v2 0/2] Do not change worker's running cpu in cmci_rediscover().

2012-10-19 Thread Tang Chen
Hi, CC to Tejun Heo, and add change log: Changes from v1 to v2: - split one single patch into two. - use WARN_ON_ONCE() but not BUG_ON(), as Tejun said. Thanks. :) On 10/19/2012 01:45 PM, Tang Chen wrote: 1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which

Re: [PATCH v2 0/2] Do not change worker's running cpu in cmci_rediscover().

2012-10-19 Thread Tang Chen
Hi, CC to Tejun Heo, and add change log: Changes from v1 to v2: - split one single patch into two. - use WARN_ON_ONCE() but not BUG_ON(), as Tejun said. Thanks. :) On 10/19/2012 01:45 PM, Tang Chen wrote: 1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which

[PATCH v2 0/2] Do not change worker's running cpu in cmci_rediscover().

2012-10-18 Thread Tang Chen
1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which means the corresponding cpu has already dead. As a result, it won't be accessed in the for_each_online_cpu loop. So, we could change the if(cpu == dying) statement into a WARN_ON_ONCE(). 2. cmci_rediscover() used

[PATCH v2 0/2] Do not change worker's running cpu in cmci_rediscover().

2012-10-18 Thread Tang Chen
1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which means the corresponding cpu has already dead. As a result, it won't be accessed in the for_each_online_cpu loop. So, we could change the if(cpu == dying) statement into a WARN_ON_ONCE(). 2. cmci_rediscover() used