Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-18 Thread xudong chen
On Fri, 2014-11-14 at 11:12 +0800, xudong chen wrote: > On Thu, 2014-11-13 at 19:31 +0100, Wolfram Sang wrote: > > > MTK I2C HW has some limitation. > > > 1. If the i2c_msg number is more than one, STOP will be issued instead of > > > RS(Repeat Start) between each message. > > > > > > 2. Mediatek

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-18 Thread xudong chen
On Fri, 2014-11-14 at 11:12 +0800, xudong chen wrote: On Thu, 2014-11-13 at 19:31 +0100, Wolfram Sang wrote: MTK I2C HW has some limitation. 1. If the i2c_msg number is more than one, STOP will be issued instead of RS(Repeat Start) between each message. 2. Mediatek I2C controller

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-14 Thread Yingjoe Chen
On Fri, 2014-11-14 at 11:12 +0800, xudong chen wrote: > On Thu, 2014-11-13 at 19:31 +0100, Wolfram Sang wrote: > > > MT8135 and MT6589 can control I2C pins on PMIC(MT6397) by setting the i2c > > > registers in MT8135 side. > > > > I still didn't get this, even after reading the mail thread of old

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-14 Thread Yingjoe Chen
On Fri, 2014-11-14 at 11:12 +0800, xudong chen wrote: On Thu, 2014-11-13 at 19:31 +0100, Wolfram Sang wrote: MT8135 and MT6589 can control I2C pins on PMIC(MT6397) by setting the i2c registers in MT8135 side. I still didn't get this, even after reading the mail thread of old series.

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-13 Thread xudong chen
On Thu, 2014-11-13 at 19:31 +0100, Wolfram Sang wrote: > > MTK I2C HW has some limitation. > > 1. If the i2c_msg number is more than one, STOP will be issued instead of > > RS(Repeat Start) between each message. > > > > 2. Mediatek I2C controller support WRRD(write then read) mode, in WRRD > >

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-13 Thread Wolfram Sang
> MTK I2C HW has some limitation. > 1. If the i2c_msg number is more than one, STOP will be issued instead of > RS(Repeat Start) between each message. > > 2. Mediatek I2C controller support WRRD(write then read) mode, in WRRD > mode the Repeat Start will be issued between 2 messages. > In this

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-13 Thread Wolfram Sang
MTK I2C HW has some limitation. 1. If the i2c_msg number is more than one, STOP will be issued instead of RS(Repeat Start) between each message. 2. Mediatek I2C controller support WRRD(write then read) mode, in WRRD mode the Repeat Start will be issued between 2 messages. In this driver

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-13 Thread xudong chen
On Thu, 2014-11-13 at 19:31 +0100, Wolfram Sang wrote: MTK I2C HW has some limitation. 1. If the i2c_msg number is more than one, STOP will be issued instead of RS(Repeat Start) between each message. 2. Mediatek I2C controller support WRRD(write then read) mode, in WRRD mode the

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-12 Thread xudong chen
Hi, I have modify the code according the comment in patch v2. Is the any other suggestion or question for this patch? If this patch is OK, how to merger this patch? Because of the dtsi dependency patch v2 can't be merged now, can we just merge dt-bindings and I2C common driver? Thanks! On

Re: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-12 Thread xudong chen
Hi, I have modify the code according the comment in patch v2. Is the any other suggestion or question for this patch? If this patch is OK, how to merger this patch? Because of the dtsi dependency patch v2 can't be merged now, can we just merge dt-bindings and I2C common driver? Thanks! On

[PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-03 Thread Xudong Chen
This series is the second version of Mediatek SoCs I2C controller common bus driver. Compared to the first version, 1. Add comment for feature have-pmic in dt-bindings file i2c-mt6577.txt. 2. Add notes for I2C4/5/6 in mt8135.dtsi. 3. Add check compatible for the feature have-pmic in i2c-mt65xx.c,

[PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-03 Thread Xudong Chen
This series is the second version of Mediatek SoCs I2C controller common bus driver. Compared to the first version, 1. Add comment for feature have-pmic in dt-bindings file i2c-mt6577.txt. 2. Add notes for I2C4/5/6 in mt8135.dtsi. 3. Add check compatible for the feature have-pmic in i2c-mt65xx.c,