Re: [PATCH v2 0/4] Minor perf build fixes

2013-07-09 Thread Ramkumar Ramachandra
Hi Namhyung, Namhyung Kim wrote: > On Fri, 5 Jul 2013 15:46:13 +0530, Ramkumar Ramachandra wrote: >> [3/4] introduces a util/perf-perl.h to include with #pragma >> statements, hence eliminating duplication. It then updates Context.xs >> and trace-event-perl.c to use this new header. > > I

Re: [PATCH v2 0/4] Minor perf build fixes

2013-07-09 Thread Ramkumar Ramachandra
Hi Namhyung, Namhyung Kim wrote: On Fri, 5 Jul 2013 15:46:13 +0530, Ramkumar Ramachandra wrote: [3/4] introduces a util/perf-perl.h to include perl.h with #pragma statements, hence eliminating duplication. It then updates Context.xs and trace-event-perl.c to use this new header. I prefer

Re: [PATCH v2 0/4] Minor perf build fixes

2013-07-08 Thread Namhyung Kim
Hi Ramkumar, On Fri, 5 Jul 2013 15:46:13 +0530, Ramkumar Ramachandra wrote: > Hi, > > After Namhyung's review of the first iteration, I realized that I'd > made a few mistakes. This iteration should be much better. > > [1/4] is the same as before. > > [2/4] is new, and is used in [4/4]. > >

Re: [PATCH v2 0/4] Minor perf build fixes

2013-07-08 Thread Namhyung Kim
Hi Ramkumar, On Fri, 5 Jul 2013 15:46:13 +0530, Ramkumar Ramachandra wrote: Hi, After Namhyung's review of the first iteration, I realized that I'd made a few mistakes. This iteration should be much better. [1/4] is the same as before. [2/4] is new, and is used in [4/4]. [3/4]

[PATCH v2 0/4] Minor perf build fixes

2013-07-05 Thread Ramkumar Ramachandra
Hi, After Namhyung's review of the first iteration, I realized that I'd made a few mistakes. This iteration should be much better. [1/4] is the same as before. [2/4] is new, and is used in [4/4]. [3/4] introduces a util/perf-perl.h to include with #pragma statements, hence eliminating

[PATCH v2 0/4] Minor perf build fixes

2013-07-05 Thread Ramkumar Ramachandra
Hi, After Namhyung's review of the first iteration, I realized that I'd made a few mistakes. This iteration should be much better. [1/4] is the same as before. [2/4] is new, and is used in [4/4]. [3/4] introduces a util/perf-perl.h to include perl.h with #pragma statements, hence eliminating