Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread wangyijing
>> >> Please repost the series against the current tree. Also a cover >> letter with a bit more explanation would be good. >> > > Great, I think that my colleagues can send an updated version next week. I will send a new version with a cover letter these days, before that, we need to do a

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread wangyijing
>> >> Please repost the series against the current tree. Also a cover >> letter with a bit more explanation would be good. >> > > Great, I think that my colleagues can send an updated version next week. I will send a new version with a cover letter these days, before that, we need to do a

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread John Garry
On 21/04/2017 12:20, Christoph Hellwig wrote: On Fri, Apr 21, 2017 at 09:57:37AM +0100, John Garry wrote: On 21/04/2017 09:39, Johannes Thumshirn wrote: wangyijing already sent an RFC for fixing this issue (mentioned above), which was a signifiagnt rewrite of some of libsas. I am hoping that

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread John Garry
On 21/04/2017 12:20, Christoph Hellwig wrote: On Fri, Apr 21, 2017 at 09:57:37AM +0100, John Garry wrote: On 21/04/2017 09:39, Johannes Thumshirn wrote: wangyijing already sent an RFC for fixing this issue (mentioned above), which was a signifiagnt rewrite of some of libsas. I am hoping that

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Johannes Thumshirn
On Fri, Apr 21, 2017 at 01:19:41PM +0200, Christoph Hellwig wrote: > > Any reason to not just make sas_remove_host call scsi_remove_host > to ensure we get the ordering right? No other than "haven't thought of it". But let me double check the LLDDs fist. -- Johannes Thumshirn

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Johannes Thumshirn
On Fri, Apr 21, 2017 at 01:19:41PM +0200, Christoph Hellwig wrote: > > Any reason to not just make sas_remove_host call scsi_remove_host > to ensure we get the ordering right? No other than "haven't thought of it". But let me double check the LLDDs fist. -- Johannes Thumshirn

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Christoph Hellwig
On Fri, Apr 21, 2017 at 09:57:37AM +0100, John Garry wrote: > On 21/04/2017 09:39, Johannes Thumshirn wrote: >>> wangyijing already sent an RFC for fixing this issue (mentioned above), >>> > which was a signifiagnt rewrite of some of libsas. >>> > I am hoping that he would retry, and that

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Christoph Hellwig
On Fri, Apr 21, 2017 at 09:57:37AM +0100, John Garry wrote: > On 21/04/2017 09:39, Johannes Thumshirn wrote: >>> wangyijing already sent an RFC for fixing this issue (mentioned above), >>> > which was a signifiagnt rewrite of some of libsas. >>> > I am hoping that he would retry, and that

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Christoph Hellwig
On Fri, Apr 21, 2017 at 10:04:45AM +0200, Johannes Thumshirn wrote: > This series re-orders the calls to scsi_remove_host() and sas_remove_host() in > all SAS HBA drivers (apart from mpt3sas which is doing it correctly). This is > for two reasons: > 1) After the change to recursive removal

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Christoph Hellwig
On Fri, Apr 21, 2017 at 10:04:45AM +0200, Johannes Thumshirn wrote: > This series re-orders the calls to scsi_remove_host() and sas_remove_host() in > all SAS HBA drivers (apart from mpt3sas which is doing it correctly). This is > for two reasons: > 1) After the change to recursive removal

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread John Garry
On 21/04/2017 09:39, Johannes Thumshirn wrote: wangyijing already sent an RFC for fixing this issue (mentioned above), > which was a signifiagnt rewrite of some of libsas. > I am hoping that he would retry, and that community would support/shepherd > this activity, or at least say it will be

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread John Garry
On 21/04/2017 09:39, Johannes Thumshirn wrote: wangyijing already sent an RFC for fixing this issue (mentioned above), > which was a signifiagnt rewrite of some of libsas. > I am hoping that he would retry, and that community would support/shepherd > this activity, or at least say it will be

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Johannes Thumshirn
On Fri, Apr 21, 2017 at 09:34:18AM +0100, John Garry wrote: > Thanks Johannes. > > @wangyijing, can you test this patchset please (specifically 3/5)? I know > that you have the modified version of libsas which you dabbled with > upstreaming. > > On 21/04/2017 09:04, Johannes Thumshirn wrote: >

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Johannes Thumshirn
On Fri, Apr 21, 2017 at 09:34:18AM +0100, John Garry wrote: > Thanks Johannes. > > @wangyijing, can you test this patchset please (specifically 3/5)? I know > that you have the modified version of libsas which you dabbled with > upstreaming. > > On 21/04/2017 09:04, Johannes Thumshirn wrote: >

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread John Garry
Thanks Johannes. @wangyijing, can you test this patchset please (specifically 3/5)? I know that you have the modified version of libsas which you dabbled with upstreaming. On 21/04/2017 09:04, Johannes Thumshirn wrote: This series re-orders the calls to scsi_remove_host() and

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread John Garry
Thanks Johannes. @wangyijing, can you test this patchset please (specifically 3/5)? I know that you have the modified version of libsas which you dabbled with upstreaming. On 21/04/2017 09:04, Johannes Thumshirn wrote: This series re-orders the calls to scsi_remove_host() and

[PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Johannes Thumshirn
This series re-orders the calls to scsi_remove_host() and sas_remove_host() in all SAS HBA drivers (apart from mpt3sas which is doing it correctly). This is for two reasons: 1) After the change to recursive removal of sysfs entries, we're trying to remove already removed

[PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

2017-04-21 Thread Johannes Thumshirn
This series re-orders the calls to scsi_remove_host() and sas_remove_host() in all SAS HBA drivers (apart from mpt3sas which is doing it correctly). This is for two reasons: 1) After the change to recursive removal of sysfs entries, we're trying to remove already removed