Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-20 Thread Peter Hurley
On Wed, 2012-12-19 at 15:38 -0500, Sasha Levin wrote: > On Tue, Dec 18, 2012 at 11:48 AM, Peter Hurley > wrote: > > On Tue, 2012-12-18 at 10:44 -0500, Sasha Levin wrote: > >> I'm still seeing that warning with the new patch series: > >> > >> [ 549.561769] [ cut here ] >

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-20 Thread Peter Hurley
On Wed, 2012-12-19 at 15:38 -0500, Sasha Levin wrote: On Tue, Dec 18, 2012 at 11:48 AM, Peter Hurley pe...@hurleysoftware.com wrote: On Tue, 2012-12-18 at 10:44 -0500, Sasha Levin wrote: I'm still seeing that warning with the new patch series: [ 549.561769] [ cut here

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-19 Thread Sasha Levin
On Tue, Dec 18, 2012 at 11:48 AM, Peter Hurley wrote: > On Tue, 2012-12-18 at 10:44 -0500, Sasha Levin wrote: >> I'm still seeing that warning with the new patch series: >> >> [ 549.561769] [ cut here ] >> [ 549.598755] WARNING: at drivers/tty/n_tty.c:160 >>

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-19 Thread Peter Hurley
On Wed, 2012-12-19 at 00:44 +0400, Ilya Zykov wrote: > Stress test for tty. :) > You can use this program for debug new tty changes. > Use with caution. Thanks a lot for writing this. I was really struggling to come up with a test that would exercise the code races in tty properly. I'm going test

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-19 Thread Peter Hurley
On Wed, 2012-12-19 at 00:44 +0400, Ilya Zykov wrote: Stress test for tty. :) You can use this program for debug new tty changes. Use with caution. Thanks a lot for writing this. I was really struggling to come up with a test that would exercise the code races in tty properly. I'm going test

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-19 Thread Sasha Levin
On Tue, Dec 18, 2012 at 11:48 AM, Peter Hurley pe...@hurleysoftware.com wrote: On Tue, 2012-12-18 at 10:44 -0500, Sasha Levin wrote: I'm still seeing that warning with the new patch series: [ 549.561769] [ cut here ] [ 549.598755] WARNING: at drivers/tty/n_tty.c:160

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-18 Thread Ilya Zykov
Stress test for tty. :) You can use this program for debug new tty changes. Use with caution. In any case(with/without Peter's patches) I have BUG(): BUG: unable to handle kernel NULL pointer dereference at 004c IP: [] devpts_pty_kill+0x17/0x81 PGD 48696067 PUD a79c5067 PMD 0 Oops:

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-18 Thread Peter Hurley
On Tue, 2012-12-18 at 10:44 -0500, Sasha Levin wrote: > I'm still seeing that warning with the new patch series: > > [ 549.561769] [ cut here ] > [ 549.598755] WARNING: at drivers/tty/n_tty.c:160 n_tty_set_room+0xff/0x130() > [ 549.604058] scheduling buffer work for

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-18 Thread Sasha Levin
On Fri, Dec 14, 2012 at 1:22 PM, Peter Hurley wrote: > I wasn't sure if this is something to squeeze into 3.8, so don't yell > if not. At least Sasha can apply this and re-test against trinity. > > Changes in v2: > > - Please review "tty: Don't flush buffer when closing ldisc". > This patch

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-18 Thread Sasha Levin
On Fri, Dec 14, 2012 at 1:22 PM, Peter Hurley pe...@hurleysoftware.com wrote: I wasn't sure if this is something to squeeze into 3.8, so don't yell if not. At least Sasha can apply this and re-test against trinity. Changes in v2: - Please review tty: Don't flush buffer when closing ldisc.

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-18 Thread Peter Hurley
On Tue, 2012-12-18 at 10:44 -0500, Sasha Levin wrote: I'm still seeing that warning with the new patch series: [ 549.561769] [ cut here ] [ 549.598755] WARNING: at drivers/tty/n_tty.c:160 n_tty_set_room+0xff/0x130() [ 549.604058] scheduling buffer work for halted

Re: [PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-18 Thread Ilya Zykov
Stress test for tty. :) You can use this program for debug new tty changes. Use with caution. In any case(with/without Peter's patches) I have BUG(): BUG: unable to handle kernel NULL pointer dereference at 004c IP: [81116650] devpts_pty_kill+0x17/0x81 PGD 48696067 PUD

[PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-14 Thread Peter Hurley
I wasn't sure if this is something to squeeze into 3.8, so don't yell if not. At least Sasha can apply this and re-test against trinity. Changes in v2: - Please review "tty: Don't flush buffer when closing ldisc". This patch replaces the earlier "tty: Don't reschedule buffer work while

[PATCH v2 00/11] tty: Fix buffer work access-after-free

2012-12-14 Thread Peter Hurley
I wasn't sure if this is something to squeeze into 3.8, so don't yell if not. At least Sasha can apply this and re-test against trinity. Changes in v2: - Please review tty: Don't flush buffer when closing ldisc. This patch replaces the earlier tty: Don't reschedule buffer work while closing.