Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Herbert Xu
On Wed, Nov 19, 2014 at 07:30:52AM +0100, Stephan Mueller wrote: > > - these AD scatterlist chunks cannot be released after a normal encryption > operation. The associated data must be available for multiple operations. So, > while plaintext data is still flowing in, we need to keep operating

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Stephan Mueller
Am Mittwoch, 19. November 2014, 12:27:04 schrieb Herbert Xu: Hi Herbert, > On Wed, Nov 19, 2014 at 05:20:42AM +0100, Stephan Mueller wrote: > > When looking deeper into skcipher_sendmsg, I see that the input data is > > copied into the kernel using memcpy_fromiovec. The memory is allocated > >

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Herbert Xu
On Wed, Nov 19, 2014 at 05:20:42AM +0100, Stephan Mueller wrote: > > When looking deeper into skcipher_sendmsg, I see that the input data is > copied > into the kernel using memcpy_fromiovec. The memory is allocated before the > memcpy call by skcipher_alloc_sgl. Zero-copy is done through

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Stephan Mueller
Am Dienstag, 18. November 2014, 22:06:31 schrieb Herbert Xu: Hi Herbert, > On Sun, Nov 16, 2014 at 03:23:50AM +0100, Stephan Mueller wrote: > > AEAD requires the following data in addition to normal symmetric > > > > ciphers: > > * Associated authentication data of arbitrary length > >

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Stephan Mueller
Am Dienstag, 18. November 2014, 22:06:31 schrieb Herbert Xu: Hi Herbert, > On Sun, Nov 16, 2014 at 03:23:50AM +0100, Stephan Mueller wrote: > > AEAD requires the following data in addition to normal symmetric > > > > ciphers: > > * Associated authentication data of arbitrary length > >

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Herbert Xu
On Sun, Nov 16, 2014 at 03:23:50AM +0100, Stephan Mueller wrote: > AEAD requires the following data in addition to normal symmetric > ciphers: > > * Associated authentication data of arbitrary length > > * Authentication tag for decryption > > * Length of authentication tag

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Stephan Mueller
Am Dienstag, 18. November 2014, 22:06:31 schrieb Herbert Xu: Hi Herbert, On Sun, Nov 16, 2014 at 03:23:50AM +0100, Stephan Mueller wrote: AEAD requires the following data in addition to normal symmetric ciphers: * Associated authentication data of arbitrary length *

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Stephan Mueller
Am Dienstag, 18. November 2014, 22:06:31 schrieb Herbert Xu: Hi Herbert, On Sun, Nov 16, 2014 at 03:23:50AM +0100, Stephan Mueller wrote: AEAD requires the following data in addition to normal symmetric ciphers: * Associated authentication data of arbitrary length *

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Herbert Xu
On Wed, Nov 19, 2014 at 05:20:42AM +0100, Stephan Mueller wrote: When looking deeper into skcipher_sendmsg, I see that the input data is copied into the kernel using memcpy_fromiovec. The memory is allocated before the memcpy call by skcipher_alloc_sgl. Zero-copy is done through

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Stephan Mueller
Am Mittwoch, 19. November 2014, 12:27:04 schrieb Herbert Xu: Hi Herbert, On Wed, Nov 19, 2014 at 05:20:42AM +0100, Stephan Mueller wrote: When looking deeper into skcipher_sendmsg, I see that the input data is copied into the kernel using memcpy_fromiovec. The memory is allocated before

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Herbert Xu
On Wed, Nov 19, 2014 at 07:30:52AM +0100, Stephan Mueller wrote: - these AD scatterlist chunks cannot be released after a normal encryption operation. The associated data must be available for multiple operations. So, while plaintext data is still flowing in, we need to keep operating with

Re: [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-18 Thread Herbert Xu
On Sun, Nov 16, 2014 at 03:23:50AM +0100, Stephan Mueller wrote: AEAD requires the following data in addition to normal symmetric ciphers: * Associated authentication data of arbitrary length * Authentication tag for decryption * Length of authentication tag for

[PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-15 Thread Stephan Mueller
AEAD requires the following data in addition to normal symmetric ciphers: * Associated authentication data of arbitrary length * Authentication tag for decryption * Length of authentication tag for encryption The authentication tag data is communicated as part of the

[PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD

2014-11-15 Thread Stephan Mueller
AEAD requires the following data in addition to normal symmetric ciphers: * Associated authentication data of arbitrary length * Authentication tag for decryption * Length of authentication tag for encryption The authentication tag data is communicated as part of the