Re: [PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-07 Thread Dietmar Eggemann
On 06/07/17 12:15, Viresh Kumar wrote: > On 06-07-17, 11:59, Juri Lelli wrote: >> On 06/07/17 15:52, Viresh Kumar wrote: [...] >> >> If that's the case I'm wondering however if we need explicit >> synchronization though. Otherwise both threads can read the mask as >> full, clear only their bits

Re: [PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-07 Thread Dietmar Eggemann
On 06/07/17 12:15, Viresh Kumar wrote: > On 06-07-17, 11:59, Juri Lelli wrote: >> On 06/07/17 15:52, Viresh Kumar wrote: [...] >> >> If that's the case I'm wondering however if we need explicit >> synchronization though. Otherwise both threads can read the mask as >> full, clear only their bits

Re: [PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-06 Thread Viresh Kumar
On 06-07-17, 11:59, Juri Lelli wrote: > On 06/07/17 15:52, Viresh Kumar wrote: > > CPU0 (big)CPU4 (LITTLE) > > > > if (cap_parsing_failed || > > cap_parsing_done) > > return 0; > > > >

Re: [PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-06 Thread Viresh Kumar
On 06-07-17, 11:59, Juri Lelli wrote: > On 06/07/17 15:52, Viresh Kumar wrote: > > CPU0 (big)CPU4 (LITTLE) > > > > if (cap_parsing_failed || > > cap_parsing_done) > > return 0; > > > >

Re: [PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-06 Thread Juri Lelli
Hi Viresh, On 06/07/17 15:52, Viresh Kumar wrote: > On 06-07-17, 10:49, Dietmar Eggemann wrote: [...] > > static void parsing_done_workfn(struct work_struct *work) > > { > > + free_cpumask_var(cpus_to_visit); > > cpufreq_unregister_notifier(_cpu_capacity_notifier, > >

Re: [PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-06 Thread Juri Lelli
Hi Viresh, On 06/07/17 15:52, Viresh Kumar wrote: > On 06-07-17, 10:49, Dietmar Eggemann wrote: [...] > > static void parsing_done_workfn(struct work_struct *work) > > { > > + free_cpumask_var(cpus_to_visit); > > cpufreq_unregister_notifier(_cpu_capacity_notifier, > >

Re: [PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-06 Thread Viresh Kumar
On 06-07-17, 10:49, Dietmar Eggemann wrote: > Free cpumask cpus_to_visit in case registering > init_cpu_capacity_notifier has failed or the parsing of the cpu > capacity-dmips-mhz property is done. The cpumask cpus_to_visit is > only used inside the notifier call init_cpu_capacity_callback. > >

Re: [PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-06 Thread Viresh Kumar
On 06-07-17, 10:49, Dietmar Eggemann wrote: > Free cpumask cpus_to_visit in case registering > init_cpu_capacity_notifier has failed or the parsing of the cpu > capacity-dmips-mhz property is done. The cpumask cpus_to_visit is > only used inside the notifier call init_cpu_capacity_callback. > >

[PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-06 Thread Dietmar Eggemann
Free cpumask cpus_to_visit in case registering init_cpu_capacity_notifier has failed or the parsing of the cpu capacity-dmips-mhz property is done. The cpumask cpus_to_visit is only used inside the notifier call init_cpu_capacity_callback. Cc: Greg Kroah-Hartman Cc:

[PATCH v2 01/10] drivers base/arch_topology: free cpumask cpus_to_visit

2017-07-06 Thread Dietmar Eggemann
Free cpumask cpus_to_visit in case registering init_cpu_capacity_notifier has failed or the parsing of the cpu capacity-dmips-mhz property is done. The cpumask cpus_to_visit is only used inside the notifier call init_cpu_capacity_callback. Cc: Greg Kroah-Hartman Cc: Juri Lelli Reported-by: