Re: [PATCH v2 01/10] kvm: Restrict non-existing slot state transitions

2012-12-11 Thread Alex Williamson
On Tue, 2012-12-11 at 23:39 -0200, Marcelo Tosatti wrote: > On Tue, Dec 11, 2012 at 11:29:09PM -0200, Marcelo Tosatti wrote: > > On Mon, Dec 10, 2012 at 10:32:45AM -0700, Alex Williamson wrote: > > > The API documentation states: > > > > > > When changing an existing slot, it may be moved in

Re: [PATCH v2 01/10] kvm: Restrict non-existing slot state transitions

2012-12-11 Thread Marcelo Tosatti
On Mon, Dec 10, 2012 at 10:32:45AM -0700, Alex Williamson wrote: > The API documentation states: > > When changing an existing slot, it may be moved in the guest > physical memory space, or its flags may be modified. > > An "existing slot" requires a non-zero npages (memory_size).

Re: [PATCH v2 01/10] kvm: Restrict non-existing slot state transitions

2012-12-11 Thread Marcelo Tosatti
On Tue, Dec 11, 2012 at 11:29:09PM -0200, Marcelo Tosatti wrote: > On Mon, Dec 10, 2012 at 10:32:45AM -0700, Alex Williamson wrote: > > The API documentation states: > > > > When changing an existing slot, it may be moved in the guest > > physical memory space, or its flags may be

Re: [PATCH v2 01/10] kvm: Restrict non-existing slot state transitions

2012-12-11 Thread Marcelo Tosatti
On Tue, Dec 11, 2012 at 11:29:09PM -0200, Marcelo Tosatti wrote: On Mon, Dec 10, 2012 at 10:32:45AM -0700, Alex Williamson wrote: The API documentation states: When changing an existing slot, it may be moved in the guest physical memory space, or its flags may be modified.

Re: [PATCH v2 01/10] kvm: Restrict non-existing slot state transitions

2012-12-11 Thread Marcelo Tosatti
On Mon, Dec 10, 2012 at 10:32:45AM -0700, Alex Williamson wrote: The API documentation states: When changing an existing slot, it may be moved in the guest physical memory space, or its flags may be modified. An existing slot requires a non-zero npages (memory_size). The only

Re: [PATCH v2 01/10] kvm: Restrict non-existing slot state transitions

2012-12-11 Thread Alex Williamson
On Tue, 2012-12-11 at 23:39 -0200, Marcelo Tosatti wrote: On Tue, Dec 11, 2012 at 11:29:09PM -0200, Marcelo Tosatti wrote: On Mon, Dec 10, 2012 at 10:32:45AM -0700, Alex Williamson wrote: The API documentation states: When changing an existing slot, it may be moved in the guest

[PATCH v2 01/10] kvm: Restrict non-existing slot state transitions

2012-12-10 Thread Alex Williamson
The API documentation states: When changing an existing slot, it may be moved in the guest physical memory space, or its flags may be modified. An "existing slot" requires a non-zero npages (memory_size). The only transition we should therefore allow for a non-existing slot

[PATCH v2 01/10] kvm: Restrict non-existing slot state transitions

2012-12-10 Thread Alex Williamson
The API documentation states: When changing an existing slot, it may be moved in the guest physical memory space, or its flags may be modified. An existing slot requires a non-zero npages (memory_size). The only transition we should therefore allow for a non-existing slot should