Re: [PATCH v2 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable.

2017-07-26 Thread Krzysztof Kozlowski
On Wed, Jul 26, 2017 at 11:15:25AM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > Chnage in v2 : > Error handling for things done in s3c_i2sv2_probe(). > > sound/soc/samsung/s3c2412-i2s.c |

Re: [PATCH v2 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable.

2017-07-26 Thread Mark Brown
On Wed, Jul 26, 2017 at 05:35:32PM +0530, Arvind Yadav wrote: > On Wednesday 26 July 2017 04:58 PM, Mark Brown wrote: > > On Wed, Jul 26, 2017 at 11:15:25AM +0530, Arvind Yadav wrote: > > > +err: > > > + clk_disable(s3c2412_i2s.iis_pclk); > > This will disable the clock if we failed to enable it w

Re: [PATCH v2 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable.

2017-07-26 Thread Arvind Yadav
Hi, On Wednesday 26 July 2017 04:58 PM, Mark Brown wrote: On Wed, Jul 26, 2017 at 11:15:25AM +0530, Arvind Yadav wrote: --- a/sound/soc/samsung/s3c2412-i2s.c +++ b/sound/soc/samsung/s3c2412-i2s.c @@ -65,13 +65,16 @@ static int s3c2412_i2s_probe(struct snd_soc_dai *dai) s3c2412_i2s.iis

Re: [PATCH v2 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable.

2017-07-26 Thread Mark Brown
On Wed, Jul 26, 2017 at 11:15:25AM +0530, Arvind Yadav wrote: > --- a/sound/soc/samsung/s3c2412-i2s.c > +++ b/sound/soc/samsung/s3c2412-i2s.c > @@ -65,13 +65,16 @@ static int s3c2412_i2s_probe(struct snd_soc_dai *dai) > s3c2412_i2s.iis_cclk = devm_clk_get(dai->dev, "i2sclk"); > if (IS_

[PATCH v2 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable.

2017-07-25 Thread Arvind Yadav
clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- Chnage in v2 : Error handling for things done in s3c_i2sv2_probe(). sound/soc/samsung/s3c2412-i2s.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git