Re: [PATCH v2 01/16] wl1251: fix scan behaviour while not associated

2013-12-31 Thread Pali Rohár
hey may not > be 0 terminated AFAICT. > > Potential solution is at > http://www.spinics.net/lists/linux-wireless/msg98640.html . > > Thanks, > Pavel Ok. To prevent other problems in future, I removed printing ssid and

Re: [PATCH v2 01/16] wl1251: fix scan behaviour while not associated

2013-12-11 Thread Ben Hutchings
On Tue, 2013-12-10 at 18:08 +0100, Pali Rohár wrote: > On Tuesday 10 December 2013 16:41:04 Kalle Valo wrote: > > Pavel Machek writes: > > > ssids can have \0s in them... and what is worse, they may > > > not be 0 terminated AFAICT. > > > > > > Potential solution is at > > > http://www.spinics.ne

Re: [PATCH v2 01/16] wl1251: fix scan behaviour while not associated

2013-12-10 Thread Ивайло Димитров
> Оригинално писмо >От: Pali Rohár >Относно: Re: [PATCH v2 01/16] wl1251: fix scan behaviour while not associated >До: Kalle Valo , Pavel Machek >Изпратено на: Вторник, 2013, Декември 10 19:08:44 EET > > >On Tuesday 10 December 2013 1

Re: [PATCH v2 01/16] wl1251: fix scan behaviour while not associated

2013-12-10 Thread Pali Rohár
On Tuesday 10 December 2013 16:41:04 Kalle Valo wrote: > Pavel Machek writes: > > ssids can have \0s in them... and what is worse, they may > > not be 0 terminated AFAICT. > > > > Potential solution is at > > http://www.spinics.net/lists/linux-wireless/msg98640.html . > > I just use print_hex_du

Re: [PATCH v2 01/16] wl1251: fix scan behaviour while not associated

2013-12-10 Thread Kalle Valo
Pavel Machek writes: > ssids can have \0s in them... and what is worse, they may not be 0 > terminated AFAICT. > > Potential solution is at > http://www.spinics.net/lists/linux-wireless/msg98640.html . I just use print_hex_dump_bytes() to print SSIDs. -- Kalle Valo -- To unsubscribe from this

Re: [PATCH v2 01/16] wl1251: fix scan behaviour while not associated

2013-12-10 Thread Pavel Machek
Hi! > diff --git a/drivers/net/wireless/ti/wl1251/cmd.c > b/drivers/net/wireless/ti/wl1251/cmd.c > index 6822b84..16b6479 100644 > --- a/drivers/net/wireless/ti/wl1251/cmd.c > +++ b/drivers/net/wireless/ti/wl1251/cmd.c > @@ -410,7 +411,10 @@ int wl1251_cmd_scan(struct wl1251 *wl, u8 *ssid, size_t

[PATCH v2 01/16] wl1251: fix scan behaviour while not associated

2013-12-08 Thread Pali Rohár
From: David Gnedt With a dissacociated card I often encoutered very long scan delays. My guess is that it has something to do with the cards DTIM handling and another firmware bug mentioned in the TI WLAN driver, which is described as the card may never end scanning if the channel is overloaded