Re: [PATCH v2 01/26] mm: gup: rename "nonblocking" to "locked" where proper

2019-02-21 Thread Peter Xu
On Thu, Feb 21, 2019 at 10:17:42AM -0500, Jerome Glisse wrote: > On Tue, Feb 12, 2019 at 10:56:07AM +0800, Peter Xu wrote: > > There's plenty of places around __get_user_pages() that has a parameter > > "nonblocking" which does not really mean that "it won't block" (because > > it can really block)

Re: [PATCH v2 01/26] mm: gup: rename "nonblocking" to "locked" where proper

2019-02-21 Thread Jerome Glisse
On Tue, Feb 12, 2019 at 10:56:07AM +0800, Peter Xu wrote: > There's plenty of places around __get_user_pages() that has a parameter > "nonblocking" which does not really mean that "it won't block" (because > it can really block) but instead it shows whether the mmap_sem is > released by up_read() d

[PATCH v2 01/26] mm: gup: rename "nonblocking" to "locked" where proper

2019-02-11 Thread Peter Xu
There's plenty of places around __get_user_pages() that has a parameter "nonblocking" which does not really mean that "it won't block" (because it can really block) but instead it shows whether the mmap_sem is released by up_read() during the page fault handling mostly when VM_FAULT_RETRY is return