Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-28 Thread Karl Beldan
On Thu, Dec 15, 2016 at 08:51:06AM +0100, Richard Weinberger wrote: > On 15.12.2016 08:09, Karl Beldan wrote: > >>> I think this should also go into -stable. > >> > >> Why? Do you have real use cases that are broken by this? I understand > > > > I do, some code adding partitions on a gluebi

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-28 Thread Karl Beldan
On Thu, Dec 15, 2016 at 08:51:06AM +0100, Richard Weinberger wrote: > On 15.12.2016 08:09, Karl Beldan wrote: > >>> I think this should also go into -stable. > >> > >> Why? Do you have real use cases that are broken by this? I understand > > > > I do, some code adding partitions on a gluebi

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Richard Weinberger
On 15.12.2016 08:09, Karl Beldan wrote: >>> I think this should also go into -stable. >> >> Why? Do you have real use cases that are broken by this? I understand > > I do, some code adding partitions on a gluebi master. What exactly are you doing? >> this is a problem, but I'm curious on how

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Richard Weinberger
On 15.12.2016 08:09, Karl Beldan wrote: >>> I think this should also go into -stable. >> >> Why? Do you have real use cases that are broken by this? I understand > > I do, some code adding partitions on a gluebi master. What exactly are you doing? >> this is a problem, but I'm curious on how

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Karl Beldan
On Wed, Dec 14, 2016 at 9:09 PM, Brian Norris wrote: > On Wed, Dec 14, 2016 at 07:24:46PM +, Karl Beldan wrote: >> On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris >> wrote: >> > On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Karl Beldan
On Wed, Dec 14, 2016 at 9:09 PM, Brian Norris wrote: > On Wed, Dec 14, 2016 at 07:24:46PM +, Karl Beldan wrote: >> On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris >> wrote: >> > On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: >> >> On Wed, 21 Sep 2016 11:43:56 +0200 >> >>

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Brian Norris
On Wed, Dec 14, 2016 at 10:12:42PM +0100, Richard Weinberger wrote: > On 14.12.2016 22:09, Brian Norris wrote: > > Also, note that this isn't a regression; it's been broken forever and > > apparently no one noticed. IMO that raises the bar a bit (but not > > impossibly so) for -stable. > > Yes.

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Brian Norris
On Wed, Dec 14, 2016 at 10:12:42PM +0100, Richard Weinberger wrote: > On 14.12.2016 22:09, Brian Norris wrote: > > Also, note that this isn't a regression; it's been broken forever and > > apparently no one noticed. IMO that raises the bar a bit (but not > > impossibly so) for -stable. > > Yes.

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Richard Weinberger
Hi! On 14.12.2016 22:09, Brian Norris wrote: > On Wed, Dec 14, 2016 at 07:24:46PM +, Karl Beldan wrote: >> On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris >> wrote: >>> On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: On Wed, 21 Sep 2016

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Richard Weinberger
Hi! On 14.12.2016 22:09, Brian Norris wrote: > On Wed, Dec 14, 2016 at 07:24:46PM +, Karl Beldan wrote: >> On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris >> wrote: >>> On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: On Wed, 21 Sep 2016 11:43:56 +0200 Daniel Walter

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Brian Norris
On Wed, Dec 14, 2016 at 07:24:46PM +, Karl Beldan wrote: > On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris > wrote: > > On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: > >> On Wed, 21 Sep 2016 11:43:56 +0200 > >> Daniel Walter

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Brian Norris
On Wed, Dec 14, 2016 at 07:24:46PM +, Karl Beldan wrote: > On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris > wrote: > > On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: > >> On Wed, 21 Sep 2016 11:43:56 +0200 > >> Daniel Walter wrote: > >> > >> > From: Richard Weinberger > >>

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Karl Beldan
On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris wrote: > On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: >> On Wed, 21 Sep 2016 11:43:56 +0200 >> Daniel Walter wrote: >> >> > From: Richard Weinberger >> > >> > If

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-12-14 Thread Karl Beldan
On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris wrote: > On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: >> On Wed, 21 Sep 2016 11:43:56 +0200 >> Daniel Walter wrote: >> >> > From: Richard Weinberger >> > >> > If the master device has callbacks for _get/put_device() >> > and this

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-09-28 Thread Brian Norris
On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: > On Wed, 21 Sep 2016 11:43:56 +0200 > Daniel Walter wrote: > > > From: Richard Weinberger > > > > If the master device has callbacks for _get/put_device() > > and this MTD has slaves a

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-09-28 Thread Brian Norris
On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote: > On Wed, 21 Sep 2016 11:43:56 +0200 > Daniel Walter wrote: > > > From: Richard Weinberger > > > > If the master device has callbacks for _get/put_device() > > and this MTD has slaves a get_mtd_device() call on paritions > > will

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-09-21 Thread Boris Brezillon
On Wed, 21 Sep 2016 11:43:56 +0200 Daniel Walter wrote: > From: Richard Weinberger > > If the master device has callbacks for _get/put_device() > and this MTD has slaves a get_mtd_device() call on paritions > will never issue the registered callbacks. >

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-09-21 Thread Boris Brezillon
On Wed, 21 Sep 2016 11:43:56 +0200 Daniel Walter wrote: > From: Richard Weinberger > > If the master device has callbacks for _get/put_device() > and this MTD has slaves a get_mtd_device() call on paritions > will never issue the registered callbacks. > Fix this by propagating

[PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-09-21 Thread Daniel Walter
From: Richard Weinberger If the master device has callbacks for _get/put_device() and this MTD has slaves a get_mtd_device() call on paritions will never issue the registered callbacks. Fix this by propagating _get/put_device() down. Reviewed-by: Boris Brezillon

[PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-09-21 Thread Daniel Walter
From: Richard Weinberger If the master device has callbacks for _get/put_device() and this MTD has slaves a get_mtd_device() call on paritions will never issue the registered callbacks. Fix this by propagating _get/put_device() down. Reviewed-by: Boris Brezillon Signed-off-by: Richard