Re: [PATCH v2 02/15] KVM: MMU: properly check last spte in fast_page_fault()

2013-10-03 Thread Xiao Guangrong
On Oct 1, 2013, at 5:23 AM, Marcelo Tosatti wrote: >> > > Unrelated to this patch: > > If vcpu->mode = OUTSIDE_GUEST_MODE, no IPI is sent > by kvm_flush_remote_tlbs. Yes. > > So how is this supposed to work again? > >/* > * Wait for all vcpus to exit guest mode and/or

Re: [PATCH v2 02/15] KVM: MMU: properly check last spte in fast_page_fault()

2013-10-03 Thread Xiao Guangrong
On Oct 1, 2013, at 5:23 AM, Marcelo Tosatti mtosa...@redhat.com wrote: Unrelated to this patch: If vcpu-mode = OUTSIDE_GUEST_MODE, no IPI is sent by kvm_flush_remote_tlbs. Yes. So how is this supposed to work again? /* * Wait for all vcpus to exit guest mode

Re: [PATCH v2 02/15] KVM: MMU: properly check last spte in fast_page_fault()

2013-09-30 Thread Marcelo Tosatti
On Thu, Sep 05, 2013 at 06:29:05PM +0800, Xiao Guangrong wrote: > Using sp->role.level instead of @level since @level is not got from the > page table hierarchy > > There is no issue in current code since the fast page fault currently only > fixes the fault caused by dirty-log that is always on

Re: [PATCH v2 02/15] KVM: MMU: properly check last spte in fast_page_fault()

2013-09-30 Thread Marcelo Tosatti
On Thu, Sep 05, 2013 at 06:29:05PM +0800, Xiao Guangrong wrote: Using sp-role.level instead of @level since @level is not got from the page table hierarchy There is no issue in current code since the fast page fault currently only fixes the fault caused by dirty-log that is always on the

[PATCH v2 02/15] KVM: MMU: properly check last spte in fast_page_fault()

2013-09-05 Thread Xiao Guangrong
Using sp->role.level instead of @level since @level is not got from the page table hierarchy There is no issue in current code since the fast page fault currently only fixes the fault caused by dirty-log that is always on the last level (level = 1) This patch makes the code more readable and

[PATCH v2 02/15] KVM: MMU: properly check last spte in fast_page_fault()

2013-09-05 Thread Xiao Guangrong
Using sp-role.level instead of @level since @level is not got from the page table hierarchy There is no issue in current code since the fast page fault currently only fixes the fault caused by dirty-log that is always on the last level (level = 1) This patch makes the code more readable and