Re: [PATCH v2 02/30] HID: wacom: store the type in wacom->shared for INTUOSHT and INTUOSHT2

2016-07-18 Thread Benjamin Tissoires
On Jul 14 2016 or thereabouts, Ping Cheng wrote: > On Wed, Jul 13, 2016 at 9:05 AM, Benjamin Tissoires > wrote: > > The type is never set but we check for it in wacom_wireless_irq(). > > Type was assigned in wacom_wireless_work [1] before we moved code > around. It somehow failed to get into waco

Re: [PATCH v2 02/30] HID: wacom: store the type in wacom->shared for INTUOSHT and INTUOSHT2

2016-07-14 Thread Ping Cheng
On Wed, Jul 13, 2016 at 9:05 AM, Benjamin Tissoires wrote: > The type is never set but we check for it in wacom_wireless_irq(). Type was assigned in wacom_wireless_work [1] before we moved code around. It somehow failed to get into wacom_parse_and_register. The value was only assigned once on sty

[PATCH v2 02/30] HID: wacom: store the type in wacom->shared for INTUOSHT and INTUOSHT2

2016-07-13 Thread Benjamin Tissoires
The type is never set but we check for it in wacom_wireless_irq(). It looks like this is a big hack from the beginning, so fill in the gap only. Untested. Signed-off-by: Benjamin Tissoires --- No changes in v2 --- drivers/hid/wacom_sys.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(