Re: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining

2020-09-08 Thread David Hildenbrand
On 07.09.20 08:45, Michal Hocko wrote: > On Fri 04-09-20 12:21:34, Andrew Morton wrote: >> On Fri, 4 Sep 2020 07:47:45 +0200 David Hildenbrand wrote: > [...] >> @@ -1589,9 +1567,7 @@ int __ref offline_pages(unsigned long st >> reason = "failure to dissolve huge pages"; >>

Re: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining

2020-09-07 Thread Michal Hocko
On Fri 04-09-20 12:21:34, Andrew Morton wrote: > On Fri, 4 Sep 2020 07:47:45 +0200 David Hildenbrand wrote: [...] > @@ -1589,9 +1567,7 @@ int __ref offline_pages(unsigned long st > reason = "failure to dissolve huge pages"; > goto

Re: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining

2020-09-04 Thread Andrew Morton
On Fri, 4 Sep 2020 07:47:45 +0200 David Hildenbrand wrote: > > > > + * PageBuddy on freed pages on other zones. > > + */ > > +if (ret) > > +drain_all_pages(zone); > > +} while (test_pages_isolated(start_pfn, end_pfn, MEMORY_OFFLINE)); > > I think we

Re: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining

2020-09-04 Thread Michal Hocko
On Fri 04-09-20 07:47:45, David Hildenbrand wrote: > > > > Am 03.09.2020 um 23:58 schrieb Andrew Morton : [...] > > @@ -1589,16 +1567,27 @@ int __ref offline_pages(unsigned long st > >reason = "failure to dissolve huge pages"; > >goto failed_removal_isolated; > >}

Re: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining

2020-09-03 Thread David Hildenbrand
> Am 03.09.2020 um 23:58 schrieb Andrew Morton : > > On Wed, 19 Aug 2020 19:59:50 +0200 David Hildenbrand > wrote: > >> We make sure that we cannot have any memory holes right at the beginning >> of offline_pages(). We no longer need walk_system_ram_range() and can >> call

Re: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining

2020-09-03 Thread Andrew Morton
On Wed, 19 Aug 2020 19:59:50 +0200 David Hildenbrand wrote: > We make sure that we cannot have any memory holes right at the beginning > of offline_pages(). We no longer need walk_system_ram_range() and can > call test_pages_isolated() and __offline_isolated_pages() directly. > > offlined_pages

Re: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining

2020-08-24 Thread Oscar Salvador
On Wed, Aug 19, 2020 at 07:59:50PM +0200, David Hildenbrand wrote: > We make sure that we cannot have any memory holes right at the beginning > of offline_pages(). We no longer need walk_system_ram_range() and can > call test_pages_isolated() and __offline_isolated_pages() directly. > >

[PATCH v2 03/10] mm/memory_hotplug: simplify page offlining

2020-08-19 Thread David Hildenbrand
We make sure that we cannot have any memory holes right at the beginning of offline_pages(). We no longer need walk_system_ram_range() and can call test_pages_isolated() and __offline_isolated_pages() directly. offlined_pages always corresponds to nr_pages, so we can simplify that. Acked-by: