Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Andi Kleen
> The only thing that was not clear to me from reviewing the module > namespace stuff a while ago was the original intent, but I confess I > actually only looked at the technical details to see if it was > applicable to the backports case, do you recall the original > motivation ? The original

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Luis R. Rodriguez
On Wed, Nov 5, 2014 at 3:09 PM, Andi Kleen wrote: >> You know, this use case seems unavoidable so I'll just proceed with the >> configurability of it. But note that it seems we're both in agreement >> that right now what you described requires more work before in any way >> shape or form folks

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Andi Kleen
> You know, this use case seems unavoidable so I'll just proceed with the > configurability of it. But note that it seems we're both in agreement > that right now what you described requires more work before in any way > shape or form folks start using it for the exact purpose you described. > I

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Luis R. Rodriguez
Andi, some reference to some of your old module namespace work below for a different use case. On Wed, Nov 05, 2014 at 10:17:38PM +0100, Johannes Berg wrote: > On Wed, 2014-11-05 at 20:42 +0100, Luis R. Rodriguez wrote: > > > > No, I mean if bp_prefix were to contain some special character like

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Johannes Berg
On Wed, 2014-11-05 at 20:42 +0100, Luis R. Rodriguez wrote: > > No, I mean if bp_prefix were to contain some special character like [. > > This can't actually happen though. > > OK if that can't happen then I don't see the point. Where by "can't happen" I mean that Kconfig probably wouldn't be

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Luis R. Rodriguez
On Wed, Nov 05, 2014 at 10:22:44AM +0100, Johannes Berg wrote: > On Wed, 2014-11-05 at 10:16 +0100, Luis R. Rodriguez wrote: > > > > IMHO this would be better handled in the code that uses the return value > > > to add things to the Kconfig dependencies, there you could just go > > > if

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Johannes Berg
On Wed, 2014-11-05 at 10:16 +0100, Luis R. Rodriguez wrote: > > IMHO this would be better handled in the code that uses the return value > > to add things to the Kconfig dependencies, there you could just go > > if integrate: > > deplist[sym] = ["BACKPORT_" + x for x in new] > > else: > >

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Luis R. Rodriguez
On Wed, Nov 05, 2014 at 08:46:36AM +0100, Johannes Berg wrote: > On Tue, 2014-11-04 at 19:18 -0800, Luis R. Rodriguez wrote: > > > @@ -71,6 +71,9 @@ def read_dependencies(depfilename): > > ret[sym].append(kconfig_exp) > > else: > > sym, dep = item.split() >

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Luis R. Rodriguez
On Wed, Nov 05, 2014 at 08:46:36AM +0100, Johannes Berg wrote: On Tue, 2014-11-04 at 19:18 -0800, Luis R. Rodriguez wrote: @@ -71,6 +71,9 @@ def read_dependencies(depfilename): ret[sym].append(kconfig_exp) else: sym, dep = item.split() +

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Johannes Berg
On Wed, 2014-11-05 at 10:16 +0100, Luis R. Rodriguez wrote: IMHO this would be better handled in the code that uses the return value to add things to the Kconfig dependencies, there you could just go if integrate: deplist[sym] = [BACKPORT_ + x for x in new] else:

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Luis R. Rodriguez
On Wed, Nov 05, 2014 at 10:22:44AM +0100, Johannes Berg wrote: On Wed, 2014-11-05 at 10:16 +0100, Luis R. Rodriguez wrote: IMHO this would be better handled in the code that uses the return value to add things to the Kconfig dependencies, there you could just go if integrate:

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Johannes Berg
On Wed, 2014-11-05 at 20:42 +0100, Luis R. Rodriguez wrote: No, I mean if bp_prefix were to contain some special character like [. This can't actually happen though. OK if that can't happen then I don't see the point. Where by can't happen I mean that Kconfig probably wouldn't be happy

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Luis R. Rodriguez
Andi, some reference to some of your old module namespace work below for a different use case. On Wed, Nov 05, 2014 at 10:17:38PM +0100, Johannes Berg wrote: On Wed, 2014-11-05 at 20:42 +0100, Luis R. Rodriguez wrote: No, I mean if bp_prefix were to contain some special character like [.

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Andi Kleen
You know, this use case seems unavoidable so I'll just proceed with the configurability of it. But note that it seems we're both in agreement that right now what you described requires more work before in any way shape or form folks start using it for the exact purpose you described. I also

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Luis R. Rodriguez
On Wed, Nov 5, 2014 at 3:09 PM, Andi Kleen a...@firstfloor.org wrote: You know, this use case seems unavoidable so I'll just proceed with the configurability of it. But note that it seems we're both in agreement that right now what you described requires more work before in any way shape or

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-05 Thread Andi Kleen
The only thing that was not clear to me from reviewing the module namespace stuff a while ago was the original intent, but I confess I actually only looked at the technical details to see if it was applicable to the backports case, do you recall the original motivation ? The original intent

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-04 Thread Johannes Berg
On Tue, 2014-11-04 at 19:18 -0800, Luis R. Rodriguez wrote: > @@ -71,6 +71,9 @@ def read_dependencies(depfilename): > ret[sym].append(kconfig_exp) > else: > sym, dep = item.split() > +if bp_prefix != 'CPTCFG_': > +dep_prefix =

[PATCH v2 03/13] backports: allow for different backport prefix

2014-11-04 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The way we backport when packaging is to minimize the amount of changes required by taking advantage of the fact that Kconfig will treat can read CONFIG_ an environment variable with getenv() when parsing menu entries. When doing integration we don't want to do this so

[PATCH v2 03/13] backports: allow for different backport prefix

2014-11-04 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com The way we backport when packaging is to minimize the amount of changes required by taking advantage of the fact that Kconfig will treat can read CONFIG_ an environment variable with getenv() when parsing menu entries. When doing integration we don't want

Re: [PATCH v2 03/13] backports: allow for different backport prefix

2014-11-04 Thread Johannes Berg
On Tue, 2014-11-04 at 19:18 -0800, Luis R. Rodriguez wrote: @@ -71,6 +71,9 @@ def read_dependencies(depfilename): ret[sym].append(kconfig_exp) else: sym, dep = item.split() +if bp_prefix != 'CPTCFG_': +dep_prefix =