On Sun, 3 Mar 2013, Felipe Balbi wrote:
> > > this is good point and, in fact, a doubt I have myself. How are we
> > > supposed to check if device is suspended ? In case it _is_ suspended we
> > > might not be able to read device's registers due to clocks possibly
> > > being gated.
> >
> > That'
On Mon, 4 Mar 2013, Vivek Gautam wrote:
> >> @@ -149,6 +150,8 @@ static int xhci_plat_probe(struct platform_device
> >> *pdev)
> >> if (ret)
> >> goto put_usb3_hcd;
> >>
> >> + pm_runtime_enable(&pdev->dev);
> >
> > This is generally not a good idea. You shouldn't enable
Hi,
On Sat, Mar 2, 2013 at 9:23 PM, Alan Stern wrote:
> On Sat, 2 Mar 2013, Vivek Gautam wrote:
>
>> By enabling runtime pm in this driver allows users of
>> xhci-plat to enter into runtime pm. This is not full
>> runtime pm support (AKA xhci-plat doesn't actually power
>> anything off when in r
Hi,
On Sun, Mar 03, 2013 at 01:21:32AM +0200, Felipe Balbi wrote:
> > I don't know much about clock handling. In general, the
> > pm_runtime_set_active() and pm_runtime_enable() parts should be done by
> > the subsystem, not the driver, whenever possible.
>
> good to know :-) Though I disagree w
Hi,
On Sat, Mar 02, 2013 at 05:02:13PM -0500, Alan Stern wrote:
> On Sat, 2 Mar 2013, Felipe Balbi wrote:
>
> > > > @@ -174,6 +177,10 @@ static int xhci_plat_remove(struct platform_device
> > > > *dev)
> > > > struct usb_hcd *hcd = platform_get_drvdata(dev);
> > > > struct xhci_
On Sat, 2 Mar 2013, Felipe Balbi wrote:
> > > @@ -174,6 +177,10 @@ static int xhci_plat_remove(struct platform_device
> > > *dev)
> > > struct usb_hcd *hcd = platform_get_drvdata(dev);
> > > struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> > >
> > > + if (!pm_runtime_suspended(&dev->dev))
> > >
Hi,
On Sat, Mar 02, 2013 at 10:53:16AM -0500, Alan Stern wrote:
> On Sat, 2 Mar 2013, Vivek Gautam wrote:
>
> > By enabling runtime pm in this driver allows users of
> > xhci-plat to enter into runtime pm. This is not full
> > runtime pm support (AKA xhci-plat doesn't actually power
> > anything
On Sat, 2 Mar 2013, Vivek Gautam wrote:
> By enabling runtime pm in this driver allows users of
> xhci-plat to enter into runtime pm. This is not full
> runtime pm support (AKA xhci-plat doesn't actually power
> anything off when in runtime suspend mode) but,
> just basic enablement.
>
> Signed-o
By enabling runtime pm in this driver allows users of
xhci-plat to enter into runtime pm. This is not full
runtime pm support (AKA xhci-plat doesn't actually power
anything off when in runtime suspend mode) but,
just basic enablement.
Signed-off-by: Vivek Gautam
CC: Doug Anderson
---
drivers/us
9 matches
Mail list logo
