Re: [PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency

On Mon, Mar 12, 2018 at 01:01:47AM -0700, Christoph Hellwig wrote: > > + if ((driver->port_type != PCIE_ANY_PORT) && > > + (driver->port_type != pci_pcie_type(pciedev->port))) > > No need for the inner braces here. Thanks, I removed them.

Re: [PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency

On Mon, Mar 12, 2018 at 01:01:47AM -0700, Christoph Hellwig wrote: > > + if ((driver->port_type != PCIE_ANY_PORT) && > > + (driver->port_type != pci_pcie_type(pciedev->port))) > > No need for the inner braces here. Thanks, I removed them.

Re: [PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency

> + if ((driver->port_type != PCIE_ANY_PORT) && > + (driver->port_type != pci_pcie_type(pciedev->port))) No need for the inner braces here. Otherwise looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency

> + if ((driver->port_type != PCIE_ANY_PORT) && > + (driver->port_type != pci_pcie_type(pciedev->port))) No need for the inner braces here. Otherwise looks good: Reviewed-by: Christoph Hellwig

[PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency

From: Bjorn Helgaas The pcie_port_bus_type must be registered before drivers that depend on it can be registered. Those drivers include: pcied_init()# PCIe native hotplug driver aer_service_init() # AER driver dpc_service_init() #

[PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency

From: Bjorn Helgaas The pcie_port_bus_type must be registered before drivers that depend on it can be registered. Those drivers include: pcied_init()# PCIe native hotplug driver aer_service_init() # AER driver dpc_service_init() # DPC driver