Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-27 Thread Rob Herring
On Sat, Jul 25, 2015 at 8:34 AM, Gregory CLEMENT wrote: > Hi Rob, > > On 12/07/2015 16:26, Rob Herring wrote: >> set_irq_flags is ARM specific with custom flags which have genirq >> equivalents. Convert drivers to use the genirq interfaces directly, so we >> can kill off set_irq_flags. The transla

Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-25 Thread Gregory CLEMENT
Hi Rob, On 12/07/2015 16:26, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST >

Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-16 Thread Russell King - ARM Linux
On Thu, Jul 16, 2015 at 09:32:20PM +0200, Robert Jarzmik wrote: > For PXA I must admit I don't yet know. I know lubbock has an UCB1400, but I > don't have it working yet, so I can't foresee the problems yet. The UCB1400 is an AC'97 device which is quite different from its predecessors, and is not

Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-16 Thread Robert Jarzmik
Russell King - ARM Linux writes: >> drivers/net/ethernet/smsc/smc911x.c >> drivers/net/ethernet/smsc/smc9194.c >> drivers/net/ethernet/smsc/smc91x.c >> >> Those might still be, but on the DT based boards the probing should be >> completely irrelevant > > SA11x0 stuff uses smc91x.c PXA uses it al

Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-16 Thread Russell King - ARM Linux
On Sun, Jul 12, 2015 at 06:43:56PM +0200, Thomas Gleixner wrote: > The probe function was added in the initial implementation of the > driver (2006), so it predates device tree. > > drivers/net/appletalk/ltpc.c > drivers/net/arcnet/com20020-isa.c > drivers/net/arcnet/com90io.c > drivers/net/arcnet

Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-16 Thread Thomas Gleixner
On Mon, 13 Jul 2015, Rob Herring wrote: > On Sun, Jul 12, 2015 at 11:43 AM, Thomas Gleixner wrote: > > So in most of the irqchip drivers, this is irrelevant. > > Agreed, but that's a separate series I think. I'm trying not to change > behavior with this series. Are you proposing I do something di

Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-13 Thread Rob Herring
On Sun, Jul 12, 2015 at 11:43 AM, Thomas Gleixner wrote: > On Sun, 12 Jul 2015, Rob Herring wrote: > >> set_irq_flags is ARM specific with custom flags which have genirq >> equivalents. Convert drivers to use the genirq interfaces directly, so we >> can kill off set_irq_flags. The translation of f

Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-12 Thread Thomas Gleixner
On Sun, 12 Jul 2015, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PRO

[PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-12 Thread Rob Herring
set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq interfaces directly, so we can kill off set_irq_flags. The translation of flags is as follows: IRQF_VALID -> !IRQ_NOREQUEST IRQF_PROBE -> !IRQ_NOPROBE IRQF_NOAUTOEN -> IRQ_NOAUTOEN For