Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-08 Thread Stephen Boyd
Quoting Jonathan Marek (2020-09-03 16:26:39) > On 9/2/20 7:02 PM, Stephen Boyd wrote: > > > +static int qcom_qmp_phy_configure_dp_phy(struct qmp_phy *qphy) > > +{ [...] > > + writel(0x05, qphy->pcs + QSERDES_V3_DP_PHY_CFG); > > + writel(0x01, qphy->pcs + QSERDES_V3_DP_PHY_CFG); > > +

Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-04 Thread Jonathan Marek
On 9/4/20 8:57 AM, Dmitry Baryshkov wrote: On 04/09/2020 15:44, Jonathan Marek wrote: On 9/4/20 8:29 AM, Dmitry Baryshkov wrote: On 03/09/2020 23:43, Jonathan Marek wrote: On 9/2/20 7:02 PM, Stephen Boyd wrote: Add support for the USB3 + DisplayPort (DP) "combo" phy to the qmp phy driver. We

Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-04 Thread Dmitry Baryshkov
On 04/09/2020 15:44, Jonathan Marek wrote: On 9/4/20 8:29 AM, Dmitry Baryshkov wrote: On 03/09/2020 23:43, Jonathan Marek wrote: On 9/2/20 7:02 PM, Stephen Boyd wrote: Add support for the USB3 + DisplayPort (DP) "combo" phy to the qmp phy driver. We already have support for the USB3 part of

Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-04 Thread Jonathan Marek
On 9/4/20 8:29 AM, Dmitry Baryshkov wrote: On 03/09/2020 23:43, Jonathan Marek wrote: On 9/2/20 7:02 PM, Stephen Boyd wrote: Add support for the USB3 + DisplayPort (DP) "combo" phy to the qmp phy driver. We already have support for the USB3 part of the combo phy, so most additions are for the

Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-04 Thread Dmitry Baryshkov
On 03/09/2020 23:43, Jonathan Marek wrote: On 9/2/20 7:02 PM, Stephen Boyd wrote: Add support for the USB3 + DisplayPort (DP) "combo" phy to the qmp phy driver. We already have support for the USB3 part of the combo phy, so most additions are for the DP phy. Split up the

Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-03 Thread Jonathan Marek
On 9/2/20 7:02 PM, Stephen Boyd wrote: ... +static int qcom_qmp_phy_configure_dp_phy(struct qmp_phy *qphy) +{ + const struct qmp_phy_dp_clks *dp_clks = qphy->dp_clks; + const struct phy_configure_opts_dp *dp_opts = >dp_opts; + u32 val, phy_vco_div, status; + unsigned

Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-03 Thread Jonathan Marek
On 9/3/20 6:41 PM, Stephen Boyd wrote: Quoting Jonathan Marek (2020-09-03 13:43:10) On 9/2/20 7:02 PM, Stephen Boyd wrote: This code is based on a submission of this phy and PLL in the drm subsystem. I updated my upstream-based sm8150/sm8250 displayport stack [1] to use these patches.

Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-03 Thread Stephen Boyd
Quoting Jonathan Marek (2020-09-03 13:43:10) > On 9/2/20 7:02 PM, Stephen Boyd wrote: > > > > This code is based on a submission of this phy and PLL in the drm > > subsystem. > > I updated my upstream-based sm8150/sm8250 displayport stack [1] to use > these patches. Great! > > This commit

Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-03 Thread Jonathan Marek
On 9/2/20 7:02 PM, Stephen Boyd wrote: Add support for the USB3 + DisplayPort (DP) "combo" phy to the qmp phy driver. We already have support for the USB3 part of the combo phy, so most additions are for the DP phy. Split up the qcom_qmp_phy{enable,disable}() functions into the phy init, power

[PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-02 Thread Stephen Boyd
Add support for the USB3 + DisplayPort (DP) "combo" phy to the qmp phy driver. We already have support for the USB3 part of the combo phy, so most additions are for the DP phy. Split up the qcom_qmp_phy{enable,disable}() functions into the phy init, power on, power off, and exit functions that