Re: [PATCH v2 08/12] scsi/NCR5380: adopt dprintk()

2014-04-25 Thread Michael Schmitz
Acked-by: Michael Schmitz All NCR5380 drivers already include the NCR5380.h header. Better to adopt those macros rather than have three variations on them. Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380 and sun3_NCR5380 versions are inflexible. For example, they

Re: [PATCH v2 08/12] scsi/NCR5380: adopt dprintk()

2014-04-25 Thread Michael Schmitz
Acked-by: Michael Schmitz schm...@debian.org All NCR5380 drivers already include the NCR5380.h header. Better to adopt those macros rather than have three variations on them. Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380 and sun3_NCR5380 versions are inflexible.

[PATCH v2 08/12] scsi/NCR5380: adopt dprintk()

2014-03-19 Thread Finn Thain
All NCR5380 drivers already include the NCR5380.h header. Better to adopt those macros rather than have three variations on them. Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380 and sun3_NCR5380 versions are inflexible. For example, they can't accomodate

[PATCH v2 08/12] scsi/NCR5380: adopt dprintk()

2014-03-19 Thread Finn Thain
All NCR5380 drivers already include the NCR5380.h header. Better to adopt those macros rather than have three variations on them. Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380 and sun3_NCR5380 versions are inflexible. For example, they can't accomodate