Re: [PATCH v2 09/11] fuse: file: limit splice_read to virtiofs

2024-01-10 Thread Miklos Szeredi
On Wed, 10 Jan 2024 at 16:19, Ahelenia Ziemiańska wrote: > > We need to find an alternative to refusing splice, since this is not > > going to fly, IMO. > The alternative is to not hold the lock. See the references in the > cover letter for why this wasn't done. IMO a potential slight perf > hit

Re: [PATCH v2 09/11] fuse: file: limit splice_read to virtiofs

2024-01-10 Thread Ahelenia Ziemiańska
On Wed, Jan 10, 2024 at 02:43:04PM +0100, Miklos Szeredi wrote: > On Thu, 21 Dec 2023 at 04:09, Ahelenia Ziemiańska > wrote: > > Potentially-blocking splice_reads are allowed for normal filesystems > > like NFS because they're blessed by root. > > > > FUSE is commonly used suid-root, and allows

Re: [PATCH v2 09/11] fuse: file: limit splice_read to virtiofs

2024-01-10 Thread Miklos Szeredi
On Thu, 21 Dec 2023 at 04:09, Ahelenia Ziemiańska wrote: > > Potentially-blocking splice_reads are allowed for normal filesystems > like NFS because they're blessed by root. > > FUSE is commonly used suid-root, and allows anyone to trivially create > a file that, when spliced from, will just

[PATCH v2 09/11] fuse: file: limit splice_read to virtiofs

2023-12-20 Thread Ahelenia Ziemiańska
Potentially-blocking splice_reads are allowed for normal filesystems like NFS because they're blessed by root. FUSE is commonly used suid-root, and allows anyone to trivially create a file that, when spliced from, will just sleep forever with the pipe lock held. The only way IPC to the fusing