Hi Jon,
On 02/12/2013 05:15 PM, Jon Hunter wrote:
>
> On 02/12/2013 01:26 AM, Peter Ujfalusi wrote:
>> On 02/11/2013 09:22 PM, Jon Hunter wrote:
>>> Good point. I just noticed that none of my omap2+ board were booting and
>>> on omap3/4 I was the panic in the twl code. I can't say that I checked
Hi Jon,
On 02/12/2013 05:15 PM, Jon Hunter wrote:
On 02/12/2013 01:26 AM, Peter Ujfalusi wrote:
On 02/11/2013 09:22 PM, Jon Hunter wrote:
Good point. I just noticed that none of my omap2+ board were booting and
on omap3/4 I was the panic in the twl code. I can't say that I checked
the
On 02/12/2013 01:26 AM, Peter Ujfalusi wrote:
> On 02/11/2013 09:22 PM, Jon Hunter wrote:
>> Good point. I just noticed that none of my omap2+ board were booting and
>> on omap3/4 I was the panic in the twl code. I can't say that I checked
>> the panic on omap2, so may be that was another
On 02/12/2013 01:26 AM, Peter Ujfalusi wrote:
On 02/11/2013 09:22 PM, Jon Hunter wrote:
Good point. I just noticed that none of my omap2+ board were booting and
on omap3/4 I was the panic in the twl code. I can't say that I checked
the panic on omap2, so may be that was another problem?
Do
On 02/11/2013 09:22 PM, Jon Hunter wrote:
> Good point. I just noticed that none of my omap2+ board were booting and
> on omap3/4 I was the panic in the twl code. I can't say that I checked
> the panic on omap2, so may be that was another problem?
Do you have insights on the code path leading to
On 02/08/2013 11:50 PM, Peter Ujfalusi wrote:
> On 02/08/2013 07:56 PM, Jon Hunter wrote:
>>> /**
>>> * twl_i2c_write - Writes a n bit register in TWL4030/TWL5030/TWL60X0
>>> * @mod_no: module number
>>> @@ -322,16 +323,17 @@ int twl_i2c_write(u8 mod_no, u8 *value, u8 reg,
>>> unsigned
On 02/08/2013 11:50 PM, Peter Ujfalusi wrote:
On 02/08/2013 07:56 PM, Jon Hunter wrote:
/**
* twl_i2c_write - Writes a n bit register in TWL4030/TWL5030/TWL60X0
* @mod_no: module number
@@ -322,16 +323,17 @@ int twl_i2c_write(u8 mod_no, u8 *value, u8 reg,
unsigned num_bytes)
On 02/11/2013 09:22 PM, Jon Hunter wrote:
Good point. I just noticed that none of my omap2+ board were booting and
on omap3/4 I was the panic in the twl code. I can't say that I checked
the panic on omap2, so may be that was another problem?
Do you have insights on the code path leading to a
On 02/08/2013 07:56 PM, Jon Hunter wrote:
>> /**
>> * twl_i2c_write - Writes a n bit register in TWL4030/TWL5030/TWL60X0
>> * @mod_no: module number
>> @@ -322,16 +323,17 @@ int twl_i2c_write(u8 mod_no, u8 *value, u8 reg,
>> unsigned num_bytes)
>> pr_err("%s: invalid module
On 01/16/2013 07:53 AM, Peter Ujfalusi wrote:
> Gather the global variables under a single structure and allocate it with
> devm_kzalloc(). It is easier to see them and if in the future we try to add
> support for multiple instance of twl in the system it is going to be much
> simpler.
>
>
On 01/16/2013 07:53 AM, Peter Ujfalusi wrote:
Gather the global variables under a single structure and allocate it with
devm_kzalloc(). It is easier to see them and if in the future we try to add
support for multiple instance of twl in the system it is going to be much
simpler.
On 02/08/2013 07:56 PM, Jon Hunter wrote:
/**
* twl_i2c_write - Writes a n bit register in TWL4030/TWL5030/TWL60X0
* @mod_no: module number
@@ -322,16 +323,17 @@ int twl_i2c_write(u8 mod_no, u8 *value, u8 reg,
unsigned num_bytes)
pr_err(%s: invalid module number %d\n,
Gather the global variables under a single structure and allocate it with
devm_kzalloc(). It is easier to see them and if in the future we try to add
support for multiple instance of twl in the system it is going to be much
simpler.
Signed-off-by: Peter Ujfalusi
---
drivers/mfd/twl-core.c | 104
Gather the global variables under a single structure and allocate it with
devm_kzalloc(). It is easier to see them and if in the future we try to add
support for multiple instance of twl in the system it is going to be much
simpler.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
14 matches
Mail list logo
