Re: [PATCH v2 1/2] ARM: dts: rk3188: correct interrupt flags

2020-10-17 Thread Heiko Stübner
Hi, Am Freitag, 2. Oktober 2020, 18:11:28 CEST schrieb Krzysztof Kozlowski: > On Thu, Sep 17, 2020 at 08:52:10PM +0200, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > > These are simple defines so they could be used in DTS but they will not

Re: [PATCH v2 1/2] ARM: dts: rk3188: correct interrupt flags

2020-10-02 Thread Krzysztof Kozlowski
On Thu, Sep 17, 2020 at 08:52:10PM +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2.

[PATCH v2 1/2] ARM: dts: rk3188: correct interrupt flags

2020-09-17 Thread Krzysztof Kozlowski
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING Correct the interrupt flags without