Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

On Fri, Nov 06, 2015 at 04:15:37PM +0800, Shunqian Zheng wrote: > On 2015年11月06日 00:13, Mark Brown wrote: > >On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: > >This looks like a simple boolean control rather than an enum - it looks > >like it's just turning antipop on and off. >

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

Mark, On 2015年11月06日 00:13, Mark Brown wrote: On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: This is basically all good, a few very minor comments below but nothing that should take any time to fix. +static const char *rk3036_codec_antipop_text[] = {"none", "work"}; +static

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

LABBE, On 2015年11月05日 20:47, LABBE Corentin wrote: On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine driver, since the

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

LABBE, On 2015年11月05日 20:47, LABBE Corentin wrote: On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

Mark, On 2015年11月06日 00:13, Mark Brown wrote: On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: This is basically all good, a few very minor comments below but nothing that should take any time to fix. +static const char *rk3036_codec_antipop_text[] = {"none", "work"}; +static

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

On Fri, Nov 06, 2015 at 04:15:37PM +0800, Shunqian Zheng wrote: > On 2015年11月06日 00:13, Mark Brown wrote: > >On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: > >This looks like a simple boolean control rather than an enum - it looks > >like it's just turning antipop on and off. >

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: This is basically all good, a few very minor comments below but nothing that should take any time to fix. > +static const char *rk3036_codec_antipop_text[] = {"none", "work"}; > +static const unsigned int

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: > From: ZhengShunQian > > RK3036 SoC integrated with an Inno audio codec. > This driver implements the functions of it. > > There is not need a special machine driver, since the > simple-card machine driver works perfect in this

[PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine driver, since the simple-card machine driver works perfect in this case. Signed-off-by: ZhengShunQian --- sound/soc/codecs/Kconfig | 4 +

[PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine driver, since the simple-card machine driver works perfect in this case. Signed-off-by: ZhengShunQian

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: > From: ZhengShunQian > > RK3036 SoC integrated with an Inno audio codec. > This driver implements the functions of it. > > There is not need a special machine driver, since the > simple-card machine driver

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: This is basically all good, a few very minor comments below but nothing that should take any time to fix. > +static const char *rk3036_codec_antipop_text[] = {"none", "work"}; > +static const unsigned int