Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns

2014-11-04 Thread Jiri Kosina
On Mon, 3 Nov 2014, Benjamin Tissoires wrote: > Reported by Dan Carpenter: > > drivers/hid/hid-logitech-hidpp.c:359 hidpp_root_get_protocol_version() warn: > should this return really be negated? > drivers/hid/hid-logitech-hidpp.c:398 hidpp_devicenametype_get_count() warn: > should this return

Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns

2014-11-04 Thread Jiri Kosina
On Mon, 3 Nov 2014, Benjamin Tissoires wrote: Reported by Dan Carpenter: drivers/hid/hid-logitech-hidpp.c:359 hidpp_root_get_protocol_version() warn: should this return really be negated? drivers/hid/hid-logitech-hidpp.c:398 hidpp_devicenametype_get_count() warn: should this return

Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns

2014-11-03 Thread Dan Carpenter
Looks good. Thanks! regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v2 1/2] HID: logitech-hidpp: fix negated returns

2014-11-03 Thread Benjamin Tissoires
Reported by Dan Carpenter: drivers/hid/hid-logitech-hidpp.c:359 hidpp_root_get_protocol_version() warn: should this return really be negated? drivers/hid/hid-logitech-hidpp.c:398 hidpp_devicenametype_get_count() warn: should this return really be negated? drivers/hid/hid-logitech-hidpp.c:417

[PATCH v2 1/2] HID: logitech-hidpp: fix negated returns

2014-11-03 Thread Benjamin Tissoires
Reported by Dan Carpenter: drivers/hid/hid-logitech-hidpp.c:359 hidpp_root_get_protocol_version() warn: should this return really be negated? drivers/hid/hid-logitech-hidpp.c:398 hidpp_devicenametype_get_count() warn: should this return really be negated? drivers/hid/hid-logitech-hidpp.c:417

Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns

2014-11-03 Thread Dan Carpenter
Looks good. Thanks! regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/